Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added customized className for rows #250

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gouruiyu
Copy link

Motivation:
When working with dat.gui, I encountered this use case where there are two set of markers with different colors to show(screenshot attached). The border left bar seems to be a good place for color indications. However, the color scheme for the gui seems to be quite fixed. Thus I modified the code to allow customized className when adding a controller row, I can then overwrite the style in customized CSS.

image

Use case:
Javascript:

Folder1.add({ marker1: false, className: "markerGreen" }, 'marker1')
    .name('Marker1')
    // everything else remain unchanged...

CSS:

  .dg .cr.markerGreen{
    border-left: 3px solid #00ff00 !important;
  }

I think it's worthwhile to allow some freedom w.r.t the color/style, but not sure if it's the best way to go. Any suggestions would be appreciated!

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@gouruiyu
Copy link
Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants