Support Elixir 17.x/Erlang OTP 27.x in CI #161
Conversation
.github/workflows/ci.yml
Outdated
| elixir: 1.11.x | ||
| otp: 21.x |
There was a problem hiding this comment.
Why change this to x?
There was a problem hiding this comment.
It supposed to pull the latest version without us explicitly set it.
Run erlef/setup-beam@v1
Installing Erlang/OTP OTP-21.3.8.24 - built on amd64/ubuntu-20.04
Using Elixir 1.11.4 (built for Erlang/OTP 21)
Installing Elixir v1.11.4-otp-21
Running mix local.rebar,--force
Running mix local.hex,--force
There was a problem hiding this comment.
Doesn't 1.11 do the same as 1.11.x?
There was a problem hiding this comment.
Indeed. The only different is the representation in the job name:
Which is your preference?
There was a problem hiding this comment.
Let's go without the x like it was before
There was a problem hiding this comment.
@whatyouhide Done.
There was a problem hiding this comment.
@kianmeng removing the quotes is also nasty because now those get treated as integers... Can we just update the latest version, without making any more cosmetic changes? 🙃
kianmeng
force-pushed
the
support-latest-elixir-erlang-in-ci
branch
from
460f27e
to
47bcbdf
Compare
kianmeng
force-pushed
the
support-latest-elixir-erlang-in-ci
branch
from
47bcbdf
to
aaa641c
Compare
|
Thanks @kianmeng 💟 |
|
🥳 🥳 🥳 🥳 🥳 |
No description provided.