Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

History data structure refactoring #666

Merged
merged 37 commits into from
Oct 9, 2024
Merged

History data structure refactoring #666

merged 37 commits into from
Oct 9, 2024

Conversation

yohamta
Copy link
Collaborator

@yohamta yohamta commented Aug 19, 2024

  • Improved latest status fetching performance

@yohamta yohamta changed the title Implement history data structure changes Implement history data structure improvements Sep 3, 2024
@yohamta yohamta changed the title Implement history data structure improvements History data structure refactoring Oct 9, 2024
@yohamta yohamta merged commit c468ffc into 1.5 Oct 9, 2024
4 checks passed
@yohamta yohamta deleted the history-store-update branch October 9, 2024 11:20
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 71.03448% with 252 lines in your changes missing coverage. Please review.

Project coverage is 63.66%. Comparing base (4065af3) to head (82a75cd).
Report is 1 commits behind head on 1.5.

Files with missing lines Patch % Lines
internal/persistence/history/jsondb/jsondb.go 69.21% 90 Missing and 59 partials ⚠️
internal/client/client.go 64.38% 25 Missing and 1 partial ⚠️
internal/dag/loader.go 76.59% 7 Missing and 4 partials ⚠️
internal/scheduler/job.go 0.00% 10 Missing ⚠️
cmd/restart.go 75.00% 4 Missing and 3 partials ⚠️
internal/agent/agent.go 73.07% 0 Missing and 7 partials ⚠️
internal/scheduler/scheduler.go 62.50% 5 Missing and 1 partial ⚠️
internal/persistence/history/model.go 88.63% 3 Missing and 2 partials ⚠️
internal/persistence/local/dag_store.go 0.00% 5 Missing ⚠️
internal/agent/reporter.go 75.00% 4 Missing ⚠️
... and 8 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              1.5     #666      +/-   ##
==========================================
- Coverage   64.08%   63.66%   -0.42%     
==========================================
  Files          53       55       +2     
  Lines        4318     4605     +287     
==========================================
+ Hits         2767     2932     +165     
- Misses       1298     1397      +99     
- Partials      253      276      +23     
Files with missing lines Coverage Δ
cmd/modules.go 100.00% <100.00%> (ø)
cmd/scheduler.go 65.71% <100.00%> (ø)
cmd/server.go 87.50% <100.00%> (ø)
cmd/status.go 75.00% <100.00%> (+1.08%) ⬆️
internal/client/interface.go 100.00% <100.00%> (ø)
internal/dag/scheduler/node.go 84.49% <100.00%> (ø)
internal/dag/step.go 100.00% <ø> (ø)
internal/logger/file.go 85.18% <100.00%> (ø)
internal/persistence/client/factory.go 92.30% <100.00%> (ø)
internal/persistence/history/jsondb/writer.go 74.46% <100.00%> (ø)
... and 21 more

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4065af3...82a75cd. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant