convert dag.Step struct to protocol buffers #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garunitule
changed the title
|
@yohamta |
|
Hi @garunitule 👋 Ohhhhh I'm sooo sorry I haven’t noticed the PR is created 😱🙇🏻♂️🙇🏻♂️🙇🏻♂️ Thank you very much for the really fantastic work!
|
yohamta
force-pushed
the
feature/protocol-buffers
branch
from
85fce44
to
23bc05f
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
partly implements #440
I have a suggestion.
I would like to create a branch for a release and create multiple PullRequests for that branch.
The reason is that it is difficult to review one huge PullRequest with all DAG, Status and Step structures migrated to Protocol Buffers.
As a first step, in this PullRequest, we have migrated only a part of Step (i.e., dag.Step also remains).