Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plugin-basic-ui): add interface to access z-index about AppScreen #514

Merged
merged 3 commits into from
Sep 11, 2024

Conversation

malangcat
Copy link
Collaborator

AppScreen 및 관련 요소들은 z-index를 사용해 스택형 UI를 구현하고 있습니다.

현재 인터페이스에서는 Popover와 같은 floating 요소를 제어할 때 "AppScreen보다 높아야 하지만, AppBar에는 가려져야 한다." 와 같은 요구사항을 해결하기 어려운 문제가 있습니다.

따라서, useAppScreen()zIndices 정보를 추가해 하위 컴포넌트에서 zIndex: zIndices.appBar - 1 과 같이 사용할 수 있도록 합니다.

Copy link

vercel bot commented Sep 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
stackflow-docs ✅ Ready (Inspect) Visit Preview Sep 11, 2024 7:02am

Copy link

changeset-bot bot commented Sep 11, 2024

🦋 Changeset detected

Latest commit: c8ce0fe

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@stackflow/plugin-basic-ui Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@tonyfromundefined tonyfromundefined left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@orionmiz orionmiz merged commit 5b1865e into main Sep 11, 2024
3 of 4 checks passed
@orionmiz orionmiz deleted the basic-ui-zindex branch September 11, 2024 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants