Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin-engines): enforce Node.js 16 #426

Merged
merged 4 commits into from
Dec 4, 2023

Conversation

scarf005
Copy link
Contributor

@scarf005 scarf005 commented Nov 29, 2023

Summary

Description

Contributing.md

image

added Node.js section with version 16 requirement.

.nvmrc

added .nvmrc with Node.js version 16 specified.

Copy link

vercel bot commented Nov 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
stackflow-docs ✅ Ready (Inspect) Visit Preview Dec 4, 2023 1:26am

@2woongjae
Copy link
Contributor

I agree to specify the version of Node.js that the package can be built on inside the Contributing.md.

Usually, the engines field in a package.json file indicates the version of Node.js on which the package works.
So it doesn't make sense to write the buildable version of the package in engines field.
That's why using yarn-plugin-engines doesn't seem appropriate.

Additionally, writing the Node.js version of the build environment in the .nvmrc file seems like a good idea considering the large number of nvm users.

@scarf005
Copy link
Contributor Author

scarf005 commented Dec 4, 2023

Usually, the engines field in a package.json file indicates the version of Node.js on which the package works.
So it doesn't make sense to write the buildable version of the package in engines field.
That's why using yarn-plugin-engines doesn't seem appropriate.

This makes sense, thanks for the insight.

@2woongjae 2woongjae self-requested a review December 4, 2023 01:17
Copy link
Contributor

@2woongjae 2woongjae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@2woongjae 2woongjae merged commit 4568376 into daangn:main Dec 4, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

빌드 가이드에 사용 Node.js 버전이 명시되면 좋겠습니다.
2 participants