Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(link): remove replace from anchorProps #407

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

DylanJu
Copy link
Contributor

@DylanJu DylanJu commented Aug 15, 2023

개요

<Link /> anchorProps에서 replace를 제거해요.

맥락

  • 기존에는 a tag에 replace=boolean attribute가 포함되어 브라우저에서 아래와 같은 워닝 메세지가 뜨고 있었어요
Warning: Received `true` for a non-boolean attribute `replace`.

If you want to write it to the DOM, pass a string instead: replace="true" or replace={value.toString()}.
  • anchorProps에서 replace 를 제거해서 a tag에 내려주지 않게 만들었어요.

고려한 대안

  • replace를 string으로 치환해서 내려주는 방법도 있어요.
  • replace는 현재 stackflow 내부 동작에만 관여하는 props라서 제거를 선택했어요.

@vercel
Copy link

vercel bot commented Aug 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
stackflow-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 15, 2023 11:24pm

@tonyfromundefined tonyfromundefined merged commit 5dde8f5 into daangn:main Aug 16, 2023
4 checks passed
@tonyfromundefined
Copy link
Member

Successfully published:

  • @stackflow/link@1.3.10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants