Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation #148

Merged
merged 24 commits into from
Aug 22, 2024
Merged

Documentation #148

merged 24 commits into from
Aug 22, 2024

Conversation

jlenain
Copy link
Collaborator

@jlenain jlenain commented Aug 21, 2024

This PR expands on #130 , #141 , #143 and #146 on the documentation.

It also should partly resolve #145 as now "only" failed imports in some parts of nectarchain makes the doc fail in CI. The Sphinx configuration has been made less nitpicky to achieve this.

@jlenain jlenain added the documentation Improvements or additions to documentation label Aug 21, 2024
@jlenain jlenain self-assigned this Aug 21, 2024
Copy link

codecov bot commented Aug 21, 2024

Codecov Report

Attention: Patch coverage is 12.19512% with 144 lines in your changes missing coverage. Please review.

Project coverage is 48.62%. Comparing base (b306f30) to head (000bf2b).
Report is 22 commits behind head on main.

Files Patch % Lines
src/nectarchain/dqm/start_dqm.py 0.00% 128 Missing ⚠️
src/nectarchain/tools/write_camera_calibration.py 0.00% 7 Missing ⚠️
...in/makers/calibration/gain/WhiteTargetSPEMakers.py 0.00% 4 Missing ⚠️
src/nectarchain/tools/write_pedestals.py 0.00% 3 Missing ⚠️
src/nectarchain/dqm/bokeh_app/main.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #148      +/-   ##
==========================================
+ Coverage   40.76%   48.62%   +7.85%     
==========================================
  Files          65       64       -1     
  Lines        4452     4586     +134     
==========================================
+ Hits         1815     2230     +415     
+ Misses       2637     2356     -281     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jlenain jlenain merged commit b4a2ef7 into cta-observatory:main Aug 22, 2024
10 of 11 checks passed
@jlenain jlenain deleted the docs2 branch August 22, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doc CI
1 participant