Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migration of flatfield and pedestal components from lstchain #2519

Closed
wants to merge 5 commits into from
Closed

Migration of flatfield and pedestal components from lstchain #2519

wants to merge 5 commits into from

Commits on Feb 27, 2024

  1. migration of flatfield and pedestal components from lstchain 

    This commit adds a migration proposal for the flatfield and pedestal components from lstchain into ctapipe.

Shared functionality is moved into a parent component, while the different subcomponents hold the _process() function for the conventional processing of flatfield and pedestal events.

Additional subcomponents with complex proccesing routines of flatfield and pedestal events can be added in the future.
    Tjark Miener authored and Tjark Miener committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    7878c44 View commit details
    Browse the repository at this point in the history

  2. implemented comments 

    Add TODOs for comments that need further dicussion.
    Tjark Miener authored and Tjark Miener committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    e013970 View commit details
    Browse the repository at this point in the history

  3. return DL1CameraContainer directly

    Tjark Miener authored and Tjark Miener committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    af9d063 View commit details
    Browse the repository at this point in the history

  4. check validity of sample size and update frequency

    Tjark Miener authored and Tjark Miener committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    98066fa View commit details
    Browse the repository at this point in the history

  5. fix typo

    Tjark Miener authored and Tjark Miener committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    4ed7915 View commit details
    Browse the repository at this point in the history