Angular error regressor #2503
Angular error regressor #2503
Conversation
|
Can you define "angular error"? It would be useful to explain the use case for this, and what it does in the description. I suspect the name "angular error" may be too generic - there are many angles we reconstruct, which one is this referring to? |
|
This PR also seems to include #2497, maybe it should be parented to that branch? |
|
With angular error I mean the angular difference between the true direction and the reconstructed direction of an event. This is useful to define event types in terms of the quality of the reconstruction. |
I suggest naming it "DirectionReconstructionError" or something more clear, since AngularError could refer to other angles. Or maybe better yet "DirectionReconstructionUncertainty" to avoid the class being confused with RuntimeErrors... Or just "DirectionUncertaintly" if you want something shorter... |
|
|
||
| result = Table( | ||
| { | ||
| f"{self.reconstructor_prefix}_ang_distance_uncert": ang_error, | ||
| f"{self.reconstructor_prefix}_direction_uncertainty": dir_uncert, |
There was a problem hiding this comment.
This column name actually needs to stay the same, as it comes from the definitions in ctapipe.containers.
There was a problem hiding this comment.
could also just rename it to direction_uncertainty, since we have not really used that column up to now. It's technically a data model change, but again, that column was never filled, so shouldn't cause a problem.
There was a problem hiding this comment.
The stereo combiner fills this column when combining alt/az predictions by disp. But I don't think this was used for anything up until now, so changing it shouldn't be a problem (and direction_uncertainty is a better name imo).
…torization functions
LukasBeiske
force-pushed
the
angular-error-regressor
branch
from
210ec77
to
34b6f8d
Compare
Adding tools to reconstruct the angular error at the DL2 level. Which will allow the definition of event types based on the angular reconstruction quality.