Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better warning message in R0 to R0G #1285

Merged
merged 4 commits into from
Sep 5, 2024
Merged

Conversation

moralejo
Copy link
Collaborator

@moralejo moralejo commented Sep 4, 2024

The previous message suggested an action which is not actually needed in most cases.

@moralejo moralejo marked this pull request as draft September 4, 2024 18:08
Copy link

codecov bot commented Sep 4, 2024

Codecov Report

Attention: Patch coverage is 37.50000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 73.49%. Comparing base (378a4c3) to head (ed795b1).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
lstchain/scripts/lstchain_r0_to_r0g.py 37.50% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1285      +/-   ##
==========================================
- Coverage   73.49%   73.49%   -0.01%     
==========================================
  Files         134      134              
  Lines       14207    14210       +3     
==========================================
+ Hits        10442    10443       +1     
- Misses       3765     3767       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

lstchain/scripts/lstchain_r0_to_r0g.py Outdated Show resolved Hide resolved
moralejo and others added 2 commits September 5, 2024 09:36
Co-authored-by: Daniel Morcuende <dmorcuende@iaa.es>
@moralejo moralejo marked this pull request as ready for review September 5, 2024 08:39
@moralejo moralejo merged commit 4f7ed59 into main Sep 5, 2024
7 of 9 checks passed
@moralejo moralejo deleted the untagged_FF_like_warning branch September 5, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants