Fix unusable pixels usage in muon analysis #1151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxnoe
reviewed
Aug 30, 2023
lstchain/reco/r0_to_dl1.py
Outdated
| @@ -661,7 +661,8 @@ def r0_to_dl1( | |||
|
|
|||
| # Muon ring analysis, for real data only (MC is done starting from DL1 files) | |||
| if not is_simu: | |||
| bad_pixels = event.mon.tel[telescope_id].calibration.unusable_pixels[0] | |||
| bad_pixels = source.r0_r1_calibrator.mon_data.tel[telescope_id].calibration.unusable_pixels[0] | |||
There was a problem hiding this comment.
Maybe add a comment that we want to use the fixed pixel list from the loaded calibration file instead of the new calibration maybe filled into event.mon?
Otherwise looks good.
maxnoe
reviewed
Aug 30, 2023
maxnoe
previously approved these changes
Aug 30, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1151 +/- ##
=======================================
Coverage 73.75% 73.75%
=======================================
Files 124 124
Lines 12589 12590 +1
=======================================
+ Hits 9285 9286 +1
Misses 3304 3304
☔ View full report in Codecov by Sentry. |
morcuended
approved these changes
Aug 30, 2023
|
offtopic: why a pre-commit action is running in this PR? |
|
I enabled it by accident for the whole |
maxnoe
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solves #1150