clippy: do not fail the scan if clippy fails to install

py/plugins/clippy.py

@@ -1,10 +1,10 @@
 import os
 
-import csmock.common.util
+from csmock.common.util import write_toolver_from_rpmlist
 
 RUN_CLIPPY_CONVERT = "/usr/share/csmock/scripts/convert-clippy.py"
 CLIPPY_OUTPUT = "/builddir/clippy-output.txt"
-CLIPPY_INSTALL = "/usr/share/csmock/scripts/inject-clippy.sh"
+CLIPPY_INJECT_SCRIPT = "/usr/share/csmock/scripts/inject-clippy.sh"
 
 class PluginProps:
     def __init__(self):
@@ -28,14 +28,20 @@ def handle_args(self, parser, args, props):
         if not self.enabled:
             return
 
-        def install_clippy_hook(results, mock):
-            return mock.exec_chroot_cmd(CLIPPY_INSTALL)
-        props.post_depinst_hooks += [install_clippy_hook]
+        # install `clippy` only if the package is available in the build repos
+        props.install_opt_pkgs += ["clippy"]
 
-        props.install_pkgs += ["clippy"]
-        props.copy_out_files += [CLIPPY_OUTPUT]
+        def inject_clippy_hook(results, mock):
+            ec = write_toolver_from_rpmlist(results, mock, "clippy", "clippy")
+            if 0 != ec:
+                # a warning has already been emitted
+                return 0
+
+            # clippy was found in the buildroot -> instrument the build
+            props.copy_out_files += [CLIPPY_OUTPUT]
+            return mock.exec_chroot_cmd(CLIPPY_INJECT_SCRIPT)
 
-        csmock.common.util.install_default_toolver_hook(props, "clippy")
+        props.post_depinst_hooks += [inject_clippy_hook]
 
         def convert_hook(results):
             src = f"{results.dbgdir_raw}{CLIPPY_OUTPUT}"