Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed usage of reserved "no" language code #855

Closed
wants to merge 1 commit into from

Conversation

yevheniyJ
Copy link
Collaborator

Unfortunately YAML has set of reserved words for boolean data type https://yaml.org/type/bool.html but since no is also a valid language code we need to bypass yml validation.

Copy link

codecov bot commented Oct 14, 2024

Codecov Report

Attention: Patch coverage is 50.58824% with 42 lines in your changes missing coverage. Please review.

Project coverage is 65.58%. Comparing base (32ea5f6) to head (26501f8).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...main/java/com/crowdin/cli/properties/FileBean.java 4.55% 20 Missing and 1 partial ⚠️
...om/crowdin/cli/properties/PropertiesWithFiles.java 64.41% 20 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #855      +/-   ##
============================================
- Coverage     65.74%   65.58%   -0.15%     
  Complexity     1521     1521              
============================================
  Files           225      225              
  Lines          6233     6300      +67     
  Branches        942      950       +8     
============================================
+ Hits           4097     4131      +34     
- Misses         1592     1623      +31     
- Partials        544      546       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants