Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove spotbugs #818

Merged
merged 1 commit into from
Jun 19, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 0 additions & 21 deletions .github/workflows/codeql-analysis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,24 +28,3 @@ jobs:
uses: github/codeql-action/analyze@v3
with:
category: "/language:java"

static-analysis:
name: Static Analysis
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4

- uses: actions/setup-java@v4
with:
distribution: temurin
java-version: 17
cache: 'gradle'

- name: Run static analysis
run: ./gradlew build staticAnalysis -P staticAnalysisMarker

- uses: actions/upload-artifact@v4
with:
name: staticAnalysis
path: |
build/reports/staticAnalysis
35 changes: 0 additions & 35 deletions build.gradle
Original file line number Diff line number Diff line change
@@ -1,11 +1,9 @@
import com.github.spotbugs.snom.SpotBugsReport
import static de.fayard.refreshVersions.core.Versions.versionFor

plugins {
id 'java'
id 'io.github.goooler.shadow' //TODO find alternative
id 'jacoco'
id 'com.github.spotbugs'
id 'org.asciidoctor.jvm.convert'
}

Expand Down Expand Up @@ -104,39 +102,6 @@ jacocoTestReport {
getExecutionData().setFrom("$buildDir/jacoco/test.exec")
}

/////////////////////////
// STATIC ANALYSIS //////
/////////////////////////

spotbugs {
ignoreFailures = false
excludeFilter = file("config/spotbugs/excludeFilter.xml")
}
spotbugsMain {
onlyIf {project.hasProperty('staticAnalysisMarker')}
reports(({
html {
required = true
destination = file("$buildDir/reports/staticAnalysis/spotbugs-main.html")
stylesheet = 'fancy-hist.xsl'
}
} as Closure<NamedDomainObjectContainer<? extends SpotBugsReport>>))
}
spotbugsTest {
onlyIf {project.hasProperty('staticAnalysisMarker')}
reports(({
html {
required = true
destination = file("$buildDir/reports/staticAnalysis/spotbugs-test.html")
stylesheet = 'fancy-hist.xsl'
}
} as Closure<NamedDomainObjectContainer<? extends SpotBugsReport>>))
}

task staticAnalysis(type: GradleBuild) {
tasks = ['spotbugsMain', 'spotbugsTest']
}

task generateManpageAsciiDoc(type: JavaExec) {
dependsOn(classes)
group = "Documentation"
Expand Down
19 changes: 0 additions & 19 deletions config/spotbugs/excludeFilter.xml

This file was deleted.

2 changes: 0 additions & 2 deletions versions.properties
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,6 @@ version.com.github.crowdin..crowdin-api-client-java=1.17.1

plugin.org.asciidoctor.jvm.convert=3.3.2

plugin.com.github.spotbugs=5.2.5

plugin.io.github.goooler.shadow=8.1.7

## Jacoco Version needs manual update
Expand Down
Loading