Create cosmic_ext_tweaks.ftl #25
Clippy (Stable ~ Linux/x86_64)
Clippy was successful!
Details
Running cargo clippy took roughly ~62465ms to complete
- Working Directory: repository directory
Annotations
Check warning on line 307 in /home/runner/work/tweaks/tweaks/src/main.rs
github-actions / Clippy: Rust Stable 1.81.0 (eeb90cda1 2024-09-04)
in
/home/runner/work/tweaks/tweaks/src/main.rs#L307
manual implementation of an assign operation
Raw output
warning: manual implementation of an assign operation
--> src/app.rs:307:17
|
307 | self.offset = self.offset + self.limit;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.offset += self.limit`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
= note: `#[warn(clippy::assign_op_pattern)]` on by default
Check warning on line 308 in /home/runner/work/tweaks/tweaks/src/main.rs
github-actions / Clippy: Rust Stable 1.81.0 (eeb90cda1 2024-09-04)
in
/home/runner/work/tweaks/tweaks/src/main.rs#L308
using `clone` on type `usize` which implements the `Copy` trait
Raw output
warning: using `clone` on type `usize` which implements the `Copy` trait
--> src/app.rs:308:29
|
308 | let limit = self.limit.clone();
| ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.limit`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
= note: `#[warn(clippy::clone_on_copy)]` on by default
Check warning on line 309 in /home/runner/work/tweaks/tweaks/src/main.rs
github-actions / Clippy: Rust Stable 1.81.0 (eeb90cda1 2024-09-04)
in
/home/runner/work/tweaks/tweaks/src/main.rs#L309
using `clone` on type `usize` which implements the `Copy` trait
Raw output
warning: using `clone` on type `usize` which implements the `Copy` trait
--> src/app.rs:309:30
|
309 | let offset = self.offset.clone();
| ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.offset`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
Check warning on line 520 in /home/runner/work/tweaks/tweaks/src/main.rs
github-actions / Clippy: Rust Stable 1.81.0 (eeb90cda1 2024-09-04)
in
/home/runner/work/tweaks/tweaks/src/main.rs#L520
explicit call to `.into_iter()` in function argument accepting `IntoIterator`
Raw output
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> src/app.rs:520:24
|
520 | .chain(available.into_iter())
| ^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `available`
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/eeb90cda1969383f56a2637cbd3037bdf598841c/library/core/src/iter/traits/iterator.rs:484:12
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
= note: `#[warn(clippy::useless_conversion)]` on by default
Check warning on line 521 in /home/runner/work/tweaks/tweaks/src/main.rs
github-actions / Clippy: Rust Stable 1.81.0 (eeb90cda1 2024-09-04)
in
/home/runner/work/tweaks/tweaks/src/main.rs#L521
explicit call to `.into_iter()` in function argument accepting `IntoIterator`
Raw output
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> src/app.rs:521:24
|
521 | .chain(show_more_button.into_iter())
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `show_more_button`
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/eeb90cda1969383f56a2637cbd3037bdf598841c/library/core/src/iter/traits/iterator.rs:484:12
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion