Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: option to force panel button to display icons instead of text #20

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

ryanabx
Copy link
Contributor

@ryanabx ryanabx commented Sep 22, 2024

This commit adds the ability to tell COSMIC panel buttons (for example, the Launcher button, the App Library button, and the Workspaces button) to always present themselves as an icon on a Panel instead of being text on horizontal panels, and icons on vertical panels.

NOTE: It's a bit messy atm as I just copied the cosmic panel button config into the source here, but I don't think the config is exported in such a way that we could get it from cosmic-applets. Correct me if I'm wrong!

2024-09-22.15-38-12.mp4

src/pages/panel.rs Outdated Show resolved Hide resolved
Copy link
Member

@edfloreshz edfloreshz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few suggestions, everything else looks good! 👍🏼

@ryanabx ryanabx force-pushed the feat/icons-not-text branch 2 times, most recently from 42e3072 to 13f8fae Compare September 23, 2024 16:41
Copy link
Member

@edfloreshz edfloreshz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This commit adds the ability to tell COSMIC panel buttons (for example, the Launcher button, the App Library button, and the Workspaces button) to always present themselves as an icon on a Panel instead of being text on horizontal panels, and icons on vertical panels.

Signed-off-by: Ryan Brue <ryanbrue.dev@gmail.com>
@ryanabx
Copy link
Contributor Author

ryanabx commented Sep 23, 2024

Ok done. Almost committed with my work github lol

@edfloreshz edfloreshz merged commit 15db6c9 into cosmic-utils:main Sep 23, 2024
1 check failed
@edfloreshz
Copy link
Member

Thanks Ryan! 🎉

@ryanabx ryanabx deleted the feat/icons-not-text branch September 23, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants