Add quick settings applet #29
edfloreshzAnnotations
1 error and 10 warnings
|
build
The process '/home/runner/.cargo/bin/cargo' failed with exit code 1
|
|
manual implementation of an assign operation:
app/src/lib.rs#L304
warning: manual implementation of an assign operation
--> app/src/app.rs:304:17
|
304 | self.offset = self.offset + self.limit;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.offset += self.limit`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
= note: `#[warn(clippy::assign_op_pattern)]` on by default
|
|
using `clone` on type `usize` which implements the `Copy` trait:
app/src/lib.rs#L305
warning: using `clone` on type `usize` which implements the `Copy` trait
--> app/src/app.rs:305:29
|
305 | let limit = self.limit.clone();
| ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.limit`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
= note: `#[warn(clippy::clone_on_copy)]` on by default
|
|
using `clone` on type `usize` which implements the `Copy` trait:
app/src/lib.rs#L306
warning: using `clone` on type `usize` which implements the `Copy` trait
--> app/src/app.rs:306:30
|
306 | let offset = self.offset.clone();
| ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.offset`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
|
|
explicit call to `.into_iter()` in function argument accepting `IntoIterator`:
app/src/lib.rs#L517
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> app/src/app.rs:517:24
|
517 | .chain(available.into_iter())
| ^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `available`
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/eeb90cda1969383f56a2637cbd3037bdf598841c/library/core/src/iter/traits/iterator.rs:484:12
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
= note: `#[warn(clippy::useless_conversion)]` on by default
|
|
explicit call to `.into_iter()` in function argument accepting `IntoIterator`:
app/src/lib.rs#L518
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> app/src/app.rs:518:24
|
518 | .chain(show_more_button.into_iter())
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `show_more_button`
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/eeb90cda1969383f56a2637cbd3037bdf598841c/library/core/src/iter/traits/iterator.rs:484:12
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
app/src/lib.rs#L120
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> app/src/core/config_manager.rs:120:59
|
120 | if let Err(err) = dock_config.set_padding(&dock_handler, padding) {
| ^^^^^^^^^^^^^ help: change this to: `dock_handler`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
app/src/lib.rs#L133
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> app/src/core/config_manager.rs:133:59
|
133 | if let Err(err) = dock_config.set_spacing(&dock_handler, spacing) {
| ^^^^^^^^^^^^^ help: change this to: `dock_handler`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
app/src/lib.rs#L146
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> app/src/core/config_manager.rs:146:60
|
146 | if let Err(err) = panel_config.set_padding(&panel_handler, padding) {
| ^^^^^^^^^^^^^^ help: change this to: `panel_handler`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
app/src/lib.rs#L159
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> app/src/core/config_manager.rs:159:60
|
159 | if let Err(err) = panel_config.set_spacing(&panel_handler, spacing) {
| ^^^^^^^^^^^^^^ help: change this to: `panel_handler`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
you should consider adding a `Default` implementation for `IconCache`:
app/src/lib.rs#L20
warning: you should consider adding a `Default` implementation for `IconCache`
--> app/src/core/icons.rs:20:5
|
20 | / pub fn new() -> Self {
21 | | let mut cache = HashMap::new();
22 | |
23 | | macro_rules! bundle {
... |
49 | | Self { cache }
50 | | }
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
= note: `#[warn(clippy::new_without_default)]` on by default
help: try adding this
|
19 + impl Default for IconCache {
20 + fn default() -> Self {
21 + Self::new()
22 + }
23 + }
|
|