Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use accurate available CPU count STT-wide #2253

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/build-and-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -823,6 +823,9 @@ jobs:
# Test FLAC input
time ./bin/run-ci-ldc93s1-flac.sh --epochs 1

# Test LM gen
time ./bin/run-ci-lm-gen-batch.sh

# Test LM opt
time ./bin/run-ci-lm-opt.sh
training-sdb-tests:
Expand Down
2 changes: 2 additions & 0 deletions Dockerfile.train
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,8 @@ RUN apt-get update && \
libvorbisfile3 \
libopusfile0 \
libsndfile1 \
libboost-program-options-dev \
libboost-thread-dev \
sox \
libsox-fmt-mp3 \
python3-venv \
Expand Down
24 changes: 24 additions & 0 deletions bin/run-ci-lm-gen-batch.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
#!/bin/sh

# This test optimizes the scorer for testing purposes

set -xe

lm_path="./data/lm"
sources_lm_filepath="./data/smoke_test/vocab.txt"

# Force only one visible device because we have a single-sample dataset
# and when trying to run on multiple devices (like GPUs), this will break

python data/lm/generate_lm_batch.py \
--input_txt "${sources_lm_filepath}" \
--output_dir "${lm_path}" \
--top_k_list 30000 \
--arpa_order_list "4" \
--max_arpa_memory "85%" \
--arpa_prune_list "0|0|2" \
--binary_a_bits 255 \
--binary_q_bits 8 \
--binary_type trie \
--kenlm_bins /code/kenlm/build/bin/ \
-j 1
Empty file modified data/lm/generate_lm.py
100644 → 100755
Empty file.
260 changes: 260 additions & 0 deletions data/lm/generate_lm_batch.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,260 @@
import argparse
import gzip
import io
import os
import subprocess
import logging
from collections import Counter
import datetime, time
from pathlib import Path

import concurrent.futures
from concurrent.futures import wait

import progressbar
from clearml import Task

from generate_lm import build_lm, convert_and_filter_topk
from coqui_stt_training.util import cpu

logging.basicConfig(level=logging.INFO)

wxh = os.get_terminal_size()

LINE = "-" * wxh.lines


def generate_batch_lm(
parser_batch, arpa_order, top_k, arpa_prune, i, total_runs, output_dir
):
results = []
Path(output_dir).mkdir(parents=True, exist_ok=True)
# Create a child parser and add single elements
parser_single = argparse.ArgumentParser(
parents=[parser_batch],
add_help=False,
)
parser_single.add_argument("--arpa_order", type=int, default=arpa_order)
parser_single.add_argument("--top_k", type=int, default=top_k)
parser_single.add_argument("--arpa_prune", type=str, default=arpa_prune)
args_single = parser_single.parse_args()
args_single.output_dir = output_dir
_start_time = (
time.perf_counter()
) # We use time.perf_counter() to acurately mesure delta of t; not datetime obj nor standard time.time()
# logging.info("-" * 3 * 10)
results.append(
f"{datetime.datetime.now():%Y-%m-%d %H:%M} RUNNING {i}/{total_runs} FOR {arpa_order=} {top_k=} {arpa_prune=}"
)
# logging.info("-" * 3 * 10)
# call with these arguments
data_lower, vocab_str = convert_and_filter_topk(args_single)
build_lm(args_single, data_lower, vocab_str)
parser_single = None
os.remove(os.path.join(output_dir, "lm.arpa"))
os.remove(os.path.join(output_dir, "lm_filtered.arpa"))
os.remove(os.path.join(output_dir, "lower.txt.gz"))
results.append(
f"LM generation {i} took: {time.perf_counter() - _start_time} seconds"
)
return results


def parse_args():
n = int(cpu.available_count())
parser_batch = argparse.ArgumentParser(
description="Generate lm.binary and top-k vocab for Coqui STT in batch for multiple arpa_order, top_k and arpa_prune values."
)
parser_batch.add_argument(
"--input_txt",
help="Path to a file.txt or file.txt.gz with sample sentences",
type=str,
required=True,
)
parser_batch.add_argument(
"--output_dir", help="Directory path for the output", type=str, required=True
)
# parser.add_argument(
# "--top_k",
# help="Use top_k most frequent words for the vocab.txt file. These will be used to filter the ARPA file.",
# type=int,
# required=False,
# )
parser_batch.add_argument(
"--kenlm_bins",
help="File path to the KENLM binaries lmplz, filter and build_binary",
type=str,
required=True,
)
# parser.add_argument(
# "--arpa_order",
# help="Order of k-grams in ARPA-file generation",
# type=int,
# required=False,
# )
parser_batch.add_argument(
"--max_arpa_memory",
help="Maximum allowed memory usage for ARPA-file generation",
type=str,
required=True,
)
# parser.add_argument(
# "--arpa_prune",
# help="ARPA pruning parameters. Separate values with '|'",
# type=str,
# required=True,
# )
parser_batch.add_argument(
"--binary_a_bits",
help="Build binary quantization value a in bits",
type=int,
required=True,
)
parser_batch.add_argument(
"--binary_q_bits",
help="Build binary quantization value q in bits",
type=int,
required=True,
)
parser_batch.add_argument(
"--binary_type",
help="Build binary data structure type",
type=str,
required=True,
)
parser_batch.add_argument(
"--discount_fallback",
help="To try when such message is returned by kenlm: 'Could not calculate Kneser-Ney discounts [...] rerun with --discount_fallback'",
action="store_true",
)
parser_batch.add_argument(
"--clearml_project",
required=False,
default="STT/wav2vec2 decoding",
)
parser_batch.add_argument(
"--clearml_task",
required=False,
default="LM generation",
)

#
# The following are added for batch processing instead of single ones commented out above
#

parser_batch.add_argument(
"--arpa_order_list",
help="List of arpa_order values. Separate values with '-' (e.g. '3-4-5').",
type=str,
required=True,
)
parser_batch.add_argument(
"--top_k_list",
help="A list of top_k values. Separate values with '-' (e.g. '20000-50000').",
type=str,
required=True,
)
parser_batch.add_argument(
"--arpa_prune_list",
help="ARPA pruning parameters. Separate values with '|', groups with '-' (e.g. '0|0|1-0|0|2')",
type=str,
required=True,
)
parser_batch.add_argument(
"-j",
"--n_proc",
help=f"Maximum allowed processes. (default: {n})",
type=int,
default=n,
)

return parser_batch


def main():

args_batch = parse_args()
args_parsed_batch = args_batch.parse_args()

try:
task = Task.init(
project_name=args_parsed_batch.clearml_project,
task_name=args_parsed_batch.clearml_task,
)
except Exception:
pass

arpa_order_list = []
top_k_list = []
for x in args_parsed_batch.arpa_order_list.split("-"):
if x.isnumeric():
arpa_order_list.append(int(float(x)))
for x in args_parsed_batch.top_k_list.split("-"):
if x.isnumeric():
top_k_list.append(int(float(x)))
arpa_prune_list = args_parsed_batch.arpa_prune_list.split("-")

i = 1
total_runs = len(arpa_order_list) * len(top_k_list) * len(arpa_prune_list)
start_time = time.perf_counter()

assert int(args_parsed_batch.n_proc) <= int(
total_runs
), f"Maximum number of proc exceded given {total_runs} task(s).\n[{args_parsed_batch.n_proc=} <= {total_runs=}]\nSet the -j|--n_proc argument to a value equal or lower than {total_runs}."

n = int(args_parsed_batch.n_proc)

with concurrent.futures.ThreadPoolExecutor(max_workers=n) as executor:
futures = []
try:
for i, arpa_order in enumerate(arpa_order_list, start=1):
for top_k in top_k_list:
for arpa_prune in arpa_prune_list:
output_dir = os.path.join(
args_parsed_batch.output_dir,
f"{arpa_order}-{top_k}-{arpa_prune}",
)
future = executor.submit(
generate_batch_lm,
args_batch,
arpa_order,
top_k,
arpa_prune,
i,
total_runs,
output_dir,
)
futures.append(future)
i += 1
f = wait(futures)
print(LINE)
for d in f.done:
for r in d.result():
print(r)
print(LINE)
except KeyboardInterrupt:
print("Caught KeyboardInterrupt, terminating workers")
executor.terminate()
executor.join()

Copy link
Collaborator Author

@wasertech wasertech Oct 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

catch interrupt and raise it so main() can exit with code 1

try:
task.upload_artifact(
name="lm.binary",
artifact_object=os.path.join(args_parsed_batch.output_dir, "lm.binary"),
)
except Exception:
pass

# Delete intermediate files
# os.remove(os.path.join(args_batch.output_dir, "lower.txt.gz"))

logging.info(
f"Took {time.perf_counter() - start_time} seconds to generate {total_runs} language {'models' if total_runs > 1 else 'model'}."
)


if __name__ == "__main__":
try:
main()
except KeyboardInterrupt:
exit(1)
6 changes: 3 additions & 3 deletions training/coqui_stt_training/evaluate.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@

import json
import sys
from multiprocessing import cpu_count

import progressbar
import tensorflow.compat.v1 as tfv1
Expand All @@ -26,6 +25,7 @@
from .util.evaluate_tools import calculate_and_print_report, save_samples_json
from .util.feeding import create_dataset
from .util.helpers import check_ctcdecoder_version
from .util import cpu


def sparse_tensor_value_to_texts(value, alphabet):
Expand Down Expand Up @@ -91,8 +91,8 @@ def evaluate(test_csvs, create_model):

# Get number of accessible CPU cores for this process
try:
num_processes = cpu_count()
except NotImplementedError:
num_processes = cpu.available_count()
except Exception:
num_processes = 1

with tfv1.Session(config=Config.session_config) as session:
Expand Down
5 changes: 3 additions & 2 deletions training/coqui_stt_training/evaluate_export.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,12 @@
import wave
import io
from functools import partial
from multiprocessing import JoinableQueue, Manager, Process, cpu_count
from multiprocessing import JoinableQueue, Manager, Process

import numpy as np
from coqui_stt_training.util.evaluate_tools import calculate_and_print_report
from coqui_stt_training.util.audio import read_ogg_opus
from coqui_stt_training.util import cpu
from six.moves import range, zip

r"""
Expand Down Expand Up @@ -142,7 +143,7 @@ def parse_args():
parser.add_argument(
"--proc",
required=False,
default=cpu_count(),
default=cpu.available_count(),
type=int,
help="Number of processes to spawn, defaulting to number of CPUs",
)
Expand Down
6 changes: 3 additions & 3 deletions training/coqui_stt_training/evaluate_flashlight.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@

import json
import sys
from multiprocessing import cpu_count

import progressbar
import tensorflow.compat.v1 as tfv1
Expand All @@ -13,6 +12,7 @@
flashlight_beam_search_decoder_batch,
FlashlightDecoderState,
)
from coqui_stt_training.util import cpu
from six.moves import zip

import tensorflow as tf
Expand Down Expand Up @@ -95,8 +95,8 @@ def evaluate(test_csvs, create_model):

# Get number of accessible CPU cores for this process
try:
num_processes = cpu_count()
except NotImplementedError:
num_processes = cpu.available_count()
except Exception:
num_processes = 1

with open(Config.vocab_file) as fin:
Expand Down
Loading