Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FS-2878-format-enhancement-of-a-text-file-for-better-redability #91

Conversation

ramsharma-prog
Copy link
Contributor

@ramsharma-prog ramsharma-prog commented Jul 17, 2023

Ticket

https://dluhcdigital.atlassian.net/browse/FS-2878

Description

This PR address the following issues and improvements:

  • Eliminate hyphens from the radio field
  • Improve the readability of the monthYear field type formatting
  • Enhance the overall text file formatting to improve readability

Tests

Added unit tests

Screenshot

Screenshot 2023-07-18 at 21 06 25

Screenshot 2023-07-18 at 20 59 10

Screenshot 2023-07-18 at 21 16 44

@ramsharma-prog ramsharma-prog marked this pull request as ready for review July 18, 2023 20:11
Copy link
Contributor

@gio-karunakaran gio-karunakaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ramsharma-prog ramsharma-prog merged commit 3fceb38 into main Jul 19, 2023
5 checks passed
@ramsharma-prog ramsharma-prog deleted the FS-2878-format-enhancement-of-a-text-file-for-better-redability branch July 19, 2023 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants