Fix code scanning alert - Failure to use secure cookies #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes communitiesuk#174 Fix the code scanning alert for failure to use secure cookies. * Set the `secure` attribute to `True` in the `set_language_cookie` method in `fsd_utils/locale_selector/set_lang.py`. * Set the `samesite` attribute to `Lax` in the `set_language_cookie` method in `fsd_utils/locale_selector/set_lang.py`. * Set the `httponly` attribute to `True` in the `set_language_cookie` method in `fsd_utils/locale_selector/set_lang.py`. * Add tests in `tests/test_set_lang.py` to check if the `secure`, `samesite`, and `httponly` attributes are set correctly in the `set_language_cookie` and `select_language` methods. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/communitiesuk/funding-service-design-utils/issues/174?shareId=XXXX-XXXX-XXXX-XXXX).
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #174
Fix the code scanning alert for failure to use secure cookies.
secureattribute toTruein theset_language_cookiemethod infsd_utils/locale_selector/set_lang.py.samesiteattribute toLaxin theset_language_cookiemethod infsd_utils/locale_selector/set_lang.py.httponlyattribute toTruein theset_language_cookiemethod infsd_utils/locale_selector/set_lang.py.tests/test_set_lang.pyto check if thesecure,samesite, andhttponlyattributes are set correctly in theset_language_cookieandselect_languagemethods.For more details, open the Copilot Workspace session.