12.0 add customer team manager #319
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 12.0 #319 +/- ##
==========================================
+ Coverage 93.32% 93.54% +0.21%
==========================================
Files 310 325 +15
Lines 10832 11412 +580
Branches 1337 1418 +81
==========================================
+ Hits 10109 10675 +566
- Misses 532 537 +5
- Partials 191 200 +9 ☔ View full report in Codecov by Sentry. |
fcayre
force-pushed
the
12.0-add-customer-team-manager
branch
17 times, most recently
from
41f6b69
to
f87ffbc
Compare
fcayre
force-pushed
the
12.0-add-customer-team-manager
branch
3 times, most recently
from
92d1b77
to
85569f1
Compare
This is the first needed glue between the customer_team_manager and commown modules.
… base.group_user Clicking on Preferences displays an access error in such a case.
More roles to come, but these two are immediately necessary.
... to allow calling it with partner which already have an employee without crashing and emit an information notification summary of what was actually created and what was pre-existing.
This would require specific tests.
Archiving is the preferred way to 'forget' all about an employee.
….partner Namely: firstname, lastname, phone, image and email Note that changing an employee email that has portal access is not permitted (to customer admins) for the sake of security. Granting portal access will be made secure in an upcoming commit.
This wizard is used to warn the user this operation has security implications. It also asks the user to input its password and checks it on wizard creation (without storing it in the db, for the sake of security). The wizard can be executed on employees with any portal status as it filters out those which have already been granted the portal access.
When an employee had a role and portal access, revocation did not work because its role group implies the portal group. To fix this, we remove the portal group from the employee's (if it exists) before resetting the employee's groups.
We need it to be attractive for customers.
German translation still to be done. A duplicated message was removed to fix a gettext tool error in payment_slimpay_issue/i18n/fr.po
fcayre
force-pushed
the
12.0-add-customer-team-manager
branch
2 times, most recently
from
1cd5fd8
to
bea5665
Compare
This is done using a simple widget inherited from many2many_tags, which displays the 'description' field as a title of the displayed badge.
fcayre
force-pushed
the
12.0-add-customer-team-manager
branch
from
bea5665
to
c2bd968
Compare
... for mostly aesthetic reasons: the non-deletable Employee role is best seen at the begining of the role list, while the most-powerful one, Administration, is best at the end.
fcayre
force-pushed
the
12.0-add-customer-team-manager
branch
from
c2bd968
to
fc76481
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.