Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render the template before converting the html #318

Conversation

9184Lucky
Copy link
Collaborator

No description provided.

@9184Lucky 9184Lucky force-pushed the 12.0-fix-commown_res_partner_sms-render-template-before-converting-html branch from 5abe741 to e0ba883 Compare September 12, 2024 19:03
Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.25%. Comparing base (927d9b0) to head (3a07a6b).
Report is 6 commits behind head on 12.0.

Additional details and impacted files
@@           Coverage Diff           @@
##             12.0     #318   +/-   ##
=======================================
  Coverage   93.24%   93.25%           
=======================================
  Files         310      310           
  Lines       10750    10760   +10     
  Branches     1334     1334           
=======================================
+ Hits        10024    10034   +10     
  Misses        534      534           
  Partials      192      192           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@9184Lucky 9184Lucky force-pushed the 12.0-fix-commown_res_partner_sms-render-template-before-converting-html branch from 7dd94b1 to 9b73969 Compare September 13, 2024 09:36
@9184Lucky
Copy link
Collaborator Author

/ocabot merge patch

@github-grap-bot
Copy link
Collaborator

What a great day to merge this nice PR. Let's do it!
Prepared branch 12.0-ocabot-merge-pr-318-by-9184Lucky-bump-patch, awaiting test results.

github-grap-bot added a commit that referenced this pull request Sep 13, 2024
Signed-off-by 9184Lucky
@github-grap-bot
Copy link
Collaborator

@9184Lucky your merge command was aborted due to failed check(s), which you can inspect on this commit of 12.0-ocabot-merge-pr-318-by-9184Lucky-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@9184Lucky 9184Lucky force-pushed the 12.0-fix-commown_res_partner_sms-render-template-before-converting-html branch from 9b73969 to 3a07a6b Compare September 13, 2024 10:15
@9184Lucky
Copy link
Collaborator Author

/ocabot merge patch

@github-grap-bot
Copy link
Collaborator

What a great day to merge this nice PR. Let's do it!
Prepared branch 12.0-ocabot-merge-pr-318-by-9184Lucky-bump-patch, awaiting test results.

@github-grap-bot github-grap-bot merged commit 0ee74cb into commown:12.0 Sep 13, 2024
4 checks passed
@github-grap-bot
Copy link
Collaborator

Congratulations, your PR was merged at 23a1ca9. Thanks a lot for contributing to commown. ❤️

@9184Lucky 9184Lucky deleted the 12.0-fix-commown_res_partner_sms-render-template-before-converting-html branch September 13, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants