Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use or in partial #131

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

arjenvdhave
Copy link
Contributor

Changes

The gitinfo template should use an OR instead of an AND for the checks on lastMod and editPage
The contents of the main div already had an exist check, so it already supports ui logic for showing one or both.
However the AND used in the class attribute forced the use of both lastMod and editPage

Dark mode

  • [ x ] The UI has been tested both in dark and light mode-->

Copy link

netlify bot commented Nov 20, 2023

Deploy Preview for hugo-lotusdocs ready!

Name Link
🔨 Latest commit b680784
🔍 Latest deploy log https://app.netlify.com/sites/hugo-lotusdocs/deploys/655b703cbbdf100008598a22
😎 Deploy Preview https://deploy-preview-131--hugo-lotusdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@colinwilson colinwilson self-assigned this Nov 20, 2023
@colinwilson
Copy link
Owner

Good catch. Thank you. 👍

@colinwilson colinwilson merged commit a91c50e into colinwilson:release Nov 20, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants