Updates to 4.24.3.1.24.1

changelog.txt

@@ -1,5 +1,8 @@
 *** Sensei Pro (WC Paid Courses) ***
 
+2024-08-22 - version 4.24.3.1.24.1
+* Sensei LMS: Version bump to 4.24.3 https://raw.githubusercontent.com/Automattic/sensei/version/4.24.3/changelog.txt
+
 2024-08-08 - version 4.24.2.1.24.1
 * Sensei LMS: Version bump to 4.24.2 https://raw.githubusercontent.com/Automattic/sensei/version/4.24.2/changelog.txt
 * Sensei Pro: Version bump to 1.24.1

plugins/sensei-lms/changelog.txt

@@ -1,5 +1,13 @@
 *** Changelog ***
 
+## 4.24.3 - 2024-08-22
+### Fixed
+- Ensure quiz description is displayed to the student [#7669](https://github.com/Automattic/sensei/pull/7669)
+- Incorrect URL for edited emails [#7671](https://github.com/Automattic/sensei/pull/7671)
+- Missing lesson status icon for "complete" status [#7667](https://github.com/Automattic/sensei/pull/7667)
+- PHP deprecation notice when opening site editor [#7668](https://github.com/Automattic/sensei/pull/7668)
+- Some reports not exporting all rows [#7670](https://github.com/Automattic/sensei/pull/7670)
+
 ## 4.24.2 - 2024-08-08
 ### Security
 - Improve email templates security

plugins/sensei-lms/includes/blocks/class-sensei-block-quiz-question.php

@@ -26,18 +26,16 @@ public function __construct() {
 			],
 			Sensei()->assets->src_path( 'blocks/quiz/question-block' )
 		);
+
 		Sensei_Blocks::register_sensei_block(
 			'sensei-lms/question-description',
-			[
-				'render_callback' => '__return_empty_string',
-			],
+			[],
 			Sensei()->assets->src_path( 'blocks/quiz/question-description-block' )
 		);
+
 		Sensei_Blocks::register_sensei_block(
 			'sensei-lms/question-answers',
-			[
-				'render_callback' => '__return_empty_string',
-			],
+			[],
 			Sensei()->assets->src_path( 'blocks/quiz/question-answers-block' )
 		);
 	}

plugins/sensei-lms/includes/blocks/course-theme/class-course-navigation.php

@@ -24,6 +24,7 @@ class Course_Navigation {
 		'not-started' => 'circle',
 		'in-progress' => 'half-filled-circle',
 		'ungraded'    => 'half-filled-circle',
+		'complete'    => 'check-filled-circle',
 		'completed'   => 'check-filled-circle',
 		'failed'      => 'half-filled-circle',
 		'locked'      => 'lock',
@@ -95,7 +96,7 @@ public function render_course_navigation() {
 		$modules_html = implode(
 			'',
 			array_map(
-				function( $item ) {
+				function ( $item ) {
 					if ( 'module' === $item['type'] ) {
 						return $this->render_module( $item );
 					}
@@ -108,7 +109,7 @@ function( $item ) {
 		$lessons_html = implode(
 			'',
 			array_map(
-				function( $item ) {
+				function ( $item ) {
 					if ( 'lesson' === $item['type'] ) {
 						return $this->render_lesson( $item );
 					}
@@ -164,7 +165,7 @@ private function render_module( $module ) {
 		$lessons_html = implode(
 			'',
 			array_map(
-				function( $lesson ) {
+				function ( $lesson ) {
 					return $this->render_lesson( $lesson );
 				},
 				$lessons
@@ -175,7 +176,7 @@ function( $lesson ) {
 		$has_current_lesson = count(
 			array_filter(
 				$lessons,
-				function( $lesson ) use ( $current_lesson_id ) {
+				function ( $lesson ) use ( $current_lesson_id ) {
 					return $current_lesson_id === $lesson['id'];
 				}
 			)
@@ -186,7 +187,7 @@ function( $lesson ) use ( $current_lesson_id ) {
 		$quiz_count   = count(
 			array_filter(
 				$lessons,
-				function( $lesson ) {
+				function ( $lesson ) {
 					return \Sensei_Lesson::lesson_quiz_has_questions( $lesson['id'] );
 				}
 			)

plugins/sensei-lms/includes/class-sensei-analysis-course-list-table.php

@@ -328,7 +328,6 @@ public function generate_report( $report ) {
 		$this->search = $search;
 
 		$args = array(
-			'number'  => -1,
 			'offset'  => 0,
 			'orderby' => $orderby,
 			'order'   => $order,
@@ -347,12 +346,15 @@ public function generate_report( $report ) {
 
 		switch ( $this->view ) {
 			case 'user':
-				$this->items = $this->get_course_statuses( $args );
-				break;
+				$args['number'] = '';
+				$this->items    = $this->get_course_statuses( $args );
 
+				break;
 			case 'lesson':
 			default:
-				$this->items = $this->get_lessons( $args );
+				$args['number'] = -1;
+				$this->items    = $this->get_lessons( $args );
+
 				break;
 		}
 

plugins/sensei-lms/includes/class-sensei-analysis-lesson-list-table.php

@@ -192,7 +192,7 @@ public function generate_report( $report ) {
 		$this->search = $search;
 
 		$args = array(
-			'number'  => -1,
+			'number'  => '',
 			'offset'  => 0,
 			'orderby' => $orderby,
 			'order'   => $order,

plugins/sensei-lms/includes/class-sensei-utils.php

@@ -2917,8 +2917,9 @@ public static function is_teacher_archive_page() {
 	public static function output_query_params_as_inputs( array $excluded = [], string $url = '', bool $echo = true ) {
 		// phpcs:ignore WordPress.Security.NonceVerification -- The nonce should be checked before calling this method.
 		$query_params = $_GET;
+
 		if ( $url ) {
-			parse_str( wp_parse_url( $url, PHP_URL_QUERY ), $query_params );
+			parse_str( (string) wp_parse_url( $url, PHP_URL_QUERY ), $query_params );
 		}
 
 		$output = '';

plugins/sensei-lms/includes/internal/emails/class-email-sender.php

@@ -236,7 +236,8 @@ public function get_email_body( WP_Post $email_post, array $placeholders = [] ):
 	 */
 	private function replace_placeholders( string $content, array $placeholders ): string {
 		foreach ( $placeholders as $placeholder => $value ) {
-			$content = str_replace( '[' . $placeholder . ']', $value, $content );
+			// Strip out URL protocol if necessary. Partial solution for https://github.com/Automattic/sensei/issues/7621.
+			$content = preg_replace( '~(https?://)?\[' . $placeholder . '\]~', $value, $content );
 		}
 
 		return $content;