Merge pull request #42 from codeclimate/abh-tune-remediation-points

Tune remediation points
codeclimate · Dec 29, 2015 · f305da3 · f305da3
2 parents 038705e + 342a501
commit f305da3
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 17 deletions.
diff --git a/config/cops.yml b/config/cops.yml
@@ -1,24 +1,25 @@
 Metrics/AbcSize:
-  violation_points: 100_000
+  base_points: 1_000_000
+  violation_points: 70_000
 Metrics/BlockNesting:
-  base_points: 30_000
+  base_points: 100_000
 Metrics/ClassLength:
-  base_points: 400_000
-Metrics/CyclomaticComplexity:
-  base_points: 75_000
-  violation_points: 10_000
+  base_points: 5_000_000
+  violation_points: 35_000
+Metrics/CyclomaticComplexity: # This check is per method
+  base_points: 1_000_000
+  violation_points: 70_000
 Metrics/LineLength:
-  base_points: 20_000
-  violation_points: 5_000
-Metrics/MethodLength:
   base_points: 50_000
-  violation_points: 10_000
+Metrics/MethodLength:
+  base_points: 1_000_000
+  violation_points: 70_000
 Metrics/ModuleLength:
-  base_points: 500_000
-  violation_points: 5_000
+  base_points: 5_000_000
+  violation_points: 35_000
 Metrics/ParameterList:
-  base_points: 10_000
-  violation_points: 50_000
+  base_points: 500_000
+  violation_points: 100_000
 Metrics/PerceivedComplexity:
-  base_points: 50_000
-  violation_points: 5000
+  base_points: 1_000_000
+  violation_points: 70_000
diff --git a/spec/cc/engine/rubocop_spec.rb b/spec/cc/engine/rubocop_spec.rb
@@ -323,7 +323,7 @@ def includes_check?(output, cop_name)
       def includes_content_for?(output, cop_name)
         issue = issues(output).detect { |i| i["check_name"] =~ /#{cop_name}$/ }
 
-        issue["content"]["body"].present?
+        issue["content"] && issue["content"]["body"].present?
       end
 
       def issues(output)