fix: update code when a user is a domain admin

Signed-off-by: Youngjin Jo <youngjinjo@megazone.com>
cloudforet-io · Sep 26, 2024 · a65847e · a65847e
1 parent 7cf69c9
commit a65847e
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/src/spaceone/identity/service/workspace_group_user_service.py b/src/spaceone/identity/service/workspace_group_user_service.py
@@ -229,10 +229,12 @@ def update_role(
             params.workspace_group_id, params.domain_id
         )
 
-        workspace_group_users = workspace_group_vo.users
-        self.workspace_group_user_mgr.check_user_role_type(
-            workspace_group_users, user_id, command="update_role"
-        )
+        user_vo = self.user_mgr.get_user(user_id, domain_id)
+        if user_vo.role_type == "USER":
+            workspace_group_users = workspace_group_vo.users
+            self.workspace_group_user_mgr.check_user_role_type(
+                workspace_group_users, user_id, command="update_role"
+            )
 
         target_user_vo = self.user_mgr.get_user(target_user_id, domain_id)
         target_user_state = target_user_vo.state