Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Adding Task and TaskBuidlers #8

Merged
merged 4 commits into from
Sep 5, 2023
Merged

feat: Adding Task and TaskBuidlers #8

merged 4 commits into from
Sep 5, 2023

Conversation

nathanagood
Copy link
Contributor

  • WIP: adding objects and builders for tasks.
  • Adding more properties to Task and TaskBuilder.

Fixes #

@nathanagood
WIP: adding objects and builders for tasks.
942afd1 
Signed-off-by: Nathan Good <nathan.good@ibm.com>
@nathanagood
Adding more properties to Task and TaskBuilder.
67ef7f8 
Signed-off-by: Nathan Good <nathan.good@ibm.com>
@nathanagood nathanagood marked this pull request as draft August 29, 2023 15:11
@nathanagood
Updated tasks, tests, and task builders for more completeness.
e75d11b 
Signed-off-by: Nathan Good <nathan.good@ibm.com>
@nathanagood
Updated API.md with build.
5f530ee 
Signed-off-by: Nathan Good <nathan.good@ibm.com>
@nathanagood nathanagood marked this pull request as ready for review August 31, 2023 18:38
@nathanagood nathanagood self-assigned this Aug 31, 2023
craigcooper11
craigcooper11 approved these changes Aug 31, 2023
View reviewed changes
Copy link
Member

@craigcooper11 craigcooper11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nathanagood nathanagood merged commit f8f0b58 into develop Sep 5, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@craigcooper11 craigcooper11 craigcooper11 approved these changes

Assignees

@nathanagood nathanagood

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nathanagood @craigcooper11