use size_t for all memory length variables #675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change effects both public API and internal API and variables. It is meant to provide a consistent interface that reduces the amount of casts and increases readability of the code. Part of cisco#671.
paulej
approved these changes
Jan 5, 2024
| { | ||
| srtp_aes_icm_ctx_t *c = (srtp_aes_icm_ctx_t *)cv; | ||
| unsigned int bytes_to_encr = *enc_len; | ||
| unsigned int bytes_to_encr = (unsigned int)*enc_len; |
There was a problem hiding this comment.
Why is this one not also size_t?
There was a problem hiding this comment.
Because changing it led to a lot of other changes in in the aes code that I think require more understanding. Should maybe do it as it's own commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change effects both public API and internal API and variables. It is meant to provide a consistent interface that reduces the amount of casts and increases readability of the code.
Part of #671.