Skip to content

Commit

Permalink
Dart pub warning fixes (#19)
Browse files Browse the repository at this point in the history
* Version bump prep

* Update pubspec.yaml

* Warning fixes from dart pub
  • Loading branch information
cholojuanito authored May 23, 2023
1 parent 0edb0ae commit fb55588
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 15 deletions.
3 changes: 0 additions & 3 deletions lib/card_number.dart
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,6 @@ import 'validation_results.dart';
/// Validates the credit card number and determines
/// the credit card type as well
/// The default card number length. Set to 19
const int _DEFAULT_MAX_CARD_NUM_LENGTH = 19;

/// Default string returned on a failed validation
const String _DEFAULT_FAIL_MESSAGE = 'Invalid credit card number';

Expand Down
2 changes: 1 addition & 1 deletion lib/postal_code.dart
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import 'validation_results.dart';
/// service like Stripe or Braintree for that.
/// The default minimum postal code string length. Set to 3
const int _DEFAULT_MIN_POSTAL_CODE_LENGTH = 3;
// const int _DEFAULT_MIN_POSTAL_CODE_LENGTH = 3;

/// Checks if the postal code seems legit
ValidationResults validatePostalCode(String postalCode, {int? minLength}) {
Expand Down
11 changes: 0 additions & 11 deletions test/card_number_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -44,17 +44,6 @@ void main() {
SecurityCode.cvv(),
);

// Conflicts with typical Visa card
final CreditCardType conflictingCardType = CreditCardType(
'conflict',
'Conflict',
[16], // only length 16
{
Pattern(['4'])
},
SecurityCode.cvv(),
);

final String someMadeUpCCNumFull = "9999 6614 3472 7891";
final String someMadeUpCCNumPartial = "9999 6614 3472";
final String modifiedVisaCCNumFull = "3538243039991295";
Expand Down

0 comments on commit fb55588

Please sign in to comment.