Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify fetch() and fetch_items() in the backends #848

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vchrombie
Copy link
Member

@vchrombie vchrombie commented Aug 28, 2024

Fixes #527

I trying an attempt to solve this issue. I picked the Gitter backend to get started and see get some feedback on the changes. I will be working on rest of the backends one by one. I am sure this is going to be a huge PR, so I will take some time and add a backend each time allowing time for reviewing.

Let me know if you have any suggestions.

@vchrombie vchrombie marked this pull request as draft August 28, 2024 03:57
@vchrombie vchrombie force-pushed the 527-simply-fetch-and-fetch_items branch 5 times, most recently from 603f1ab to f9e99f1 Compare September 3, 2024 19:41
The default category is now set to the first category listed in the backend's
`CATEGORIES` list. This change is necessary to accommodate the removal of
backend-specific `fetch` methods, which previously handled category assignment.

Updated the tests to validate the default and specific category assignments,
and removed the obsolete `test_fetch_archive_needs_category`.

Signed-off-by: Venu Vardhan Reddy Tekula <vt2182@nyu.edu>
@vchrombie vchrombie force-pushed the 527-simply-fetch-and-fetch_items branch from f9e99f1 to 529c9ab Compare September 3, 2024 19:45
@sduenas
Copy link
Member

sduenas commented Sep 20, 2024

I saw two weeks ago some code to change this problem but I don't see it now. Any issues with it? Is there any way I can help?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simplify fetch() and fetch_items()
2 participants