Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[git] Fix file stats for merged files on subdirs #841

Merged
merged 2 commits into from
Jun 12, 2024

Conversation

sduenas
Copy link
Member

@sduenas sduenas commented Jun 10, 2024

Stats about changes on a file were not reported correctly for files that where moved to a subdirectory. They were reported as an invalid entry and without action associated.

For example, the file dir/filename was moved to dir/subdir/filename, but it was reported as dir//filename. Therefore, the entry of the file dir/subdire/filename didn't have the stats about added and deleted lines. This error has been fixed and stats are reported correctly.

Stats about changes on a file were not reported correctly
for files that where moved to a subdirectory. They
were reported as an invalid entry and without
action associated.

For example, the file `dir/filename` was moved to
`dir/subdir/filename`, but it was reported as `dir//filename`.
Therefore, the entry of the file `dir/subdire/filename`
didn't have the stats about added and deleted lines.
This error has been fixed and stats are reported correctly.

Signed-off-by: Santiago Dueñas <sduenas@bitergia.com>
@sduenas sduenas force-pushed the fix_git_rename_oldpath branch 4 times, most recently from 95ff439 to 46e9705 Compare June 12, 2024 08:35
This commit tries to fix the problems we have
with coveralls. It fails and the tests don't
pass on GitHub Actions.

Signed-off-by: Santiago Dueñas <sduenas@bitergia.com>
@jjmerchante
Copy link
Contributor

LGTM

@jjmerchante jjmerchante merged commit a3caa97 into chaoss:master Jun 12, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Delivered
Development

Successfully merging this pull request may close these issues.

2 participants