Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[http2_adapter] Fix redirect not working #1946

Merged
merged 2 commits into from
Sep 5, 2023
Merged

[http2_adapter] Fix redirect not working #1946

merged 2 commits into from
Sep 5, 2023

Conversation

khoadng
Copy link
Contributor

@khoadng khoadng commented Aug 30, 2023

New Pull Request Checklist

  • I have read the Documentation
  • I have searched for a similar pull request in the project and found none
  • I have updated this branch with the latest main branch to avoid conflicts (via merge from master or rebase)
  • I have added the required tests to prove the fix/feature I'm adding
  • I have updated the documentation (if necessary)
  • I have run the tests without failures
  • I have updated the CHANGELOG.md in the corresponding package

Additional context and info (if any)

@khoadng khoadng requested a review from a team as a code owner August 30, 2023 02:26
kuhnroyal
kuhnroyal approved these changes Sep 1, 2023
View reviewed changes
Copy link
Member

@kuhnroyal kuhnroyal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, good catch!

@kuhnroyal kuhnroyal added the p: http2_adapter Targeting `http2_adapter` package label Sep 5, 2023
@kuhnroyal kuhnroyal added this pull request to the merge queue Sep 5, 2023
Merged via the queue into cfug:main with commit f9e38a8 Sep 5, 2023
31 checks passed
@khoadng khoadng deleted the fix-redirect-http2 branch September 5, 2023 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kuhnroyal kuhnroyal kuhnroyal approved these changes

Assignees
No one assigned
Labels
p: http2_adapter Targeting `http2_adapter` package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@khoadng @kuhnroyal