add sendTimeout and receiveTimeout in Http2Adapter #1942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexV525
reviewed
Aug 21, 2023
AlexV525
reviewed
Aug 22, 2023
Comment on lines
+106
to
+108
| } else { | ||
| await requestStreamFuture; | ||
| } |
There was a problem hiding this comment.
TBH I'd prefer how the IO adapter wrote, future = future.timeout, etc.
There was a problem hiding this comment.
I prefer final variable rather than reassigning it
Co-authored-by: Alex Li <github@alexv525.com> Signed-off-by: sunhapper <9249052+sunhapper@users.noreply.github.com>
AlexV525
approved these changes
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add send time out and receive time for http2
New Pull Request Checklist
mainbranch to avoid conflicts (via merge from master or rebase)CHANGELOG.mdin the corresponding packageAdditional context and info (if any)
Http2Adapter only implements connect timeout，the
RequestOptions.sendTimeoutandRequestOptions.receiveTimeoutnot work.