Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔥 Remove test.sh #1897

Merged
merged 1 commit into from
Jul 17, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion dio/test/pinning_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@ import 'package:dio/io.dart';
import 'package:test/test.dart';

void main() {
// NOTE: Run test.sh to download the currrent certs to the file below.
// NOTE: Run scripts/prepare_pinning_certs.sh
// to download the current certs to the file below.
final trustedCertUrl = 'https://sha256.badssl.com/';
final untrustedCertUrl = 'https://wrong.host.badssl.com/';

Expand Down
3 changes: 2 additions & 1 deletion plugins/http2_adapter/test/pinning_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@ import 'package:dio_http2_adapter/dio_http2_adapter.dart';
import 'package:test/test.dart';

void main() {
// NOTE: Run test.sh to download the current certs to the file below.
// NOTE: Run scripts/prepare_pinning_certs.sh
// to download the current certs to the file below.
//
// OpenSSL output like: SHA256 Fingerprint=EE:5C:E1:DF:A7:A4...
// All badssl.com hosts have the same cert, they just have TLS
Expand Down
6 changes: 0 additions & 6 deletions test.sh

This file was deleted.