Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Options.compose(options) #1935

Merged
merged 2 commits into from
Aug 13, 2023
Merged

Remove Options.compose(options) #1935

merged 2 commits into from
Aug 13, 2023

Conversation

AlexV525
Copy link
Member

Removes the accidentally added options argument for Options.compose by 75cf916.

Resolves #1934.

New Pull Request Checklist

  • I have read the Documentation
  • I have searched for a similar pull request in the project and found none
  • I have updated this branch with the latest main branch to avoid conflicts (via merge from master or rebase)
  • I have added the required tests to prove the fix/feature I'm adding
  • I have updated the documentation (if necessary)
  • I have run the tests without failures
  • I have updated the CHANGELOG.md in the corresponding package

@AlexV525
Update options.dart
339e457 
Signed-off-by: Alex Li <github@alexv525.com>
@AlexV525 AlexV525 requested a review from a team as a code owner August 12, 2023 07:23
@AlexV525
Update CHANGELOG.md
c42f894 
Signed-off-by: Alex Li <github@alexv525.com>
@AlexV525
Copy link
Member Author

I was thinking that if we can make it less breakable by adding deprecation but leaving an unused argument for a long time is neither a good choice.

kuhnroyal
kuhnroyal approved these changes Aug 13, 2023
View reviewed changes
Copy link
Member

@kuhnroyal kuhnroyal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can just remove it in 6.0.0 but doesn't really matter to me.

@AlexV525 AlexV525 added this pull request to the merge queue Aug 13, 2023
Merged via the queue into main with commit 246ecfa Aug 13, 2023
31 checks passed
@AlexV525 AlexV525 deleted the fix/redundant-option-during-compose branch August 13, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kuhnroyal kuhnroyal kuhnroyal approved these changes

@ueman ueman ueman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Useless param of Compose method in options.dart
3 participants
@AlexV525 @kuhnroyal @ueman