Skip to content

Commit

Permalink
Remove Options.compose(options) (#1935)
Browse files Browse the repository at this point in the history
Removes the accidentally added `options` argument for `Options.compose`
by 75cf916.

Resolves #1934.

### New Pull Request Checklist

- [x] I have read the
[Documentation](https://pub.dev/documentation/dio/latest/)
- [x] I have searched for a similar pull request in the
[project](https://github.com/cfug/dio/pulls) and found none
- [x] I have updated this branch with the latest `main` branch to avoid
conflicts (via merge from master or rebase)
- [ ] I have added the required tests to prove the fix/feature I'm
adding
- [ ] I have updated the documentation (if necessary)
- [x] I have run the tests without failures
- [x] I have updated the `CHANGELOG.md` in the corresponding package

---------

Signed-off-by: Alex Li <github@alexv525.com>
  • Loading branch information
AlexV525 authored Aug 13, 2023
1 parent e04b791 commit 246ecfa
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 1 deletion.
1 change: 1 addition & 0 deletions dio/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ See the [Migration Guide][] for the complete breaking changes list.**
## Unreleased

- Fix failing requests throw `DioException`s with `.unknown` instead of `.connectionError` on `SocketException`.
- Removes the accidentally added `options` argument for `Options.compose`.

## 5.3.2

Expand Down
1 change: 0 additions & 1 deletion dio/lib/src/options.dart
Original file line number Diff line number Diff line change
Expand Up @@ -294,7 +294,6 @@ class Options {
Object? data,
Map<String, dynamic>? queryParameters,
CancelToken? cancelToken,
Options? options,
ProgressCallback? onSendProgress,
ProgressCallback? onReceiveProgress,
StackTrace? sourceStackTrace,
Expand Down

0 comments on commit 246ecfa

Please sign in to comment.