Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unidirectional connect without automatic error to disconnect transform #418

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

FZambia
Copy link
Member

@FZambia FZambia commented Oct 20, 2024

Now .Connect method automatically transforms any error to client protocol disconnect code. Sometimes though we want to postpone error processing, for example if we want to return some special status code in HTTP-based unidirectional transports. This PR adds .ConnectNoErrorToDisconnect method to let the caller process the error itself.

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 95.34884% with 2 lines in your changes missing coverage. Please review.

Project coverage is 82.14%. Comparing base (612c8bd) to head (c0d987e).

Files with missing lines Patch % Lines
client.go 95.12% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #418      +/-   ##
==========================================
+ Coverage   81.52%   82.14%   +0.62%     
==========================================
  Files          40       39       -1     
  Lines        7215     8560    +1345     
==========================================
+ Hits         5882     7032    +1150     
- Misses        952     1146     +194     
- Partials      381      382       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FZambia FZambia changed the title Method to unidirectional connect without automatic error transform Method to unidirectional connect without automatic error to disconnect transform Oct 22, 2024
@FZambia FZambia changed the title Method to unidirectional connect without automatic error to disconnect transform Unidirectional connect without automatic error to disconnect transform Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant