Add alternative websocket implementation via URLSessionWebSocketTask #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonselyanin
force-pushed
the
native_websockets_v2
branch
from
d3407e6
to
151d72f
Compare
FZambia
reviewed
May 10, 2023
antonselyanin
force-pushed
the
native_websockets_v2
branch
from
765b49d
to
85fc9d9
Compare
FZambia
approved these changes
May 16, 2023
…t, a remove reference cycle caused by URLSession
…cessary `syncQueue.async` calls; remove "race condition" which was occurring during disconnection process.
…n NativeWebSocket (make sure `onDisconnect` is being invoked after manual disconnect)
…s an already active connection. This should be safe, the client has it own state management (connecting, disconnected, connecting).
SergioPerm
force-pushed
the
native_websockets_v2
branch
from
a4ea866
to
593af1c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an alternative websocket implementation (via URLSessionWebSocketTask).
It is disabled by default but you can enable it via flag
useNativeWebSockets(works starting from iOS 13.0).