Prevent memory leaks when passing token getters (#92)

centrifugal · Oct 6, 2023 · 2628c8c · 2628c8c
1 parent 783e7a2
commit 2628c8c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/Sources/SwiftCentrifuge/Client.swift b/Sources/SwiftCentrifuge/Client.swift
@@ -25,7 +25,7 @@ public enum CentrifugeError: Error {
     case replyError(code: UInt32, message: String, temporary: Bool)
 }
 
-public protocol CentrifugeConnectionTokenGetter {
+public protocol CentrifugeConnectionTokenGetter: NSObject {
     func getConnectionToken(_ event: CentrifugeConnectionTokenEvent, completion: @escaping (Result<String, Error>) -> ())
 }
 
@@ -56,7 +56,7 @@ public struct CentrifugeClientConfig {
     public var name = "swift"
     public var version = ""
     public var token: String = ""
-    public var tokenGetter: CentrifugeConnectionTokenGetter?
+    public weak var tokenGetter: CentrifugeConnectionTokenGetter?
     public var data: Data? = nil
     public var debug: Bool = false
 	public var logger: CentrifugeLogger?

diff --git a/Sources/SwiftCentrifuge/Subscription.swift b/Sources/SwiftCentrifuge/Subscription.swift
@@ -8,7 +8,7 @@
 
 import Foundation
 
-public protocol CentrifugeSubscriptionTokenGetter {
+public protocol CentrifugeSubscriptionTokenGetter: NSObject {
     func getSubscriptionToken(_ event: CentrifugeSubscriptionTokenEvent, completion: @escaping (Result<String, Error>) -> ())
 }
 
@@ -33,7 +33,7 @@ public struct CentrifugeSubscriptionConfig {
     public var positioned: Bool = false
     public var recoverable: Bool = false
     public var joinLeave: Bool = false
-    public var tokenGetter: CentrifugeSubscriptionTokenGetter?
+    public weak var tokenGetter: CentrifugeSubscriptionTokenGetter?
 }
 
 public enum CentrifugeSubscriptionState {