Version 3.2.1 - Stubber changes and fixes #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Changed - Stubber now has an option to only "export" the resulting "Final" stub class and keeping all the other stubs "private" and this option is True by default (they don't really need to be public) - You can now give the resulting "Final" config stub a custom name - You can also give the "Final" config stub an empty string for a name which will simply omit generating it (for custom/complex composition of stubs later on if people want) - All stubs now also inherit from `dict` because any attribute in `BaseConfig` that's a Map (and thus has a stub class) will also behave as a `dict` (even if `Empty`) ### Fixed - Stubber now appends an underscore to stubs with Python reserved keywords like `class` and `def` etc. - The `BaseConfig` object now also spots attribute fetching of those keywords with an appended underscore and fetches the correct attribute nevertheless.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed
dictbecause any attribute inBaseConfigthat's a Map (and thus has a stub class) will also behave as adict(even ifEmpty)Fixed
classanddefetc.BaseConfigobject now also spots attribute fetching of those keywords with an appended underscore and fetches the correct attribute nevertheless.