Change default tags to empty list. Use open() to open pickle files.

ccb-hms · Nov 16, 2023 · 8b5cdd0 · 8b5cdd0
1 parent c39a408
commit 8b5cdd0
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/text2term/config.py b/text2term/config.py
@@ -1 +1 @@
-VERSION = "4.1.0"
+VERSION = "4.1.1"
diff --git a/text2term/preprocess.py b/text2term/preprocess.py
@@ -111,7 +111,7 @@ def _blocklist_term(processed_terms, term, blocklist, blocklist_char, tagged=Fal
 	return False
 
 
-def _update_tagged_term(processed_terms, term, new_term, tags=()):
+def _update_tagged_term(processed_terms, term, new_term, tags=[]):
 	term.update_term(new_term)
 	term.add_tags(tags)
 	processed_terms.append(term)

diff --git a/text2term/t2t.py b/text2term/t2t.py
@@ -180,8 +180,9 @@ def _load_ontology(ontology, iris, exclude_deprecated, use_cache=False, term_typ
     if use_cache:
         pickle_file = os.path.join("cache", ontology, ontology + "-term-details.pickle")
         LOGGER.info(f"Loading cached ontology from: {pickle_file}")
-        onto_terms_unfiltered = pickle.load(open(pickle_file, "rb"))
-        onto_terms = filter_terms(onto_terms_unfiltered, iris, exclude_deprecated, term_type)
+        with open(pickle_file, "rb") as cached_ontology_pickle:
+            onto_terms_unfiltered = pickle.load(cached_ontology_pickle)
+            onto_terms = filter_terms(onto_terms_unfiltered, iris, exclude_deprecated, term_type)
     else:
         term_collector = OntologyTermCollector(ontology_iri=ontology)
         onto_terms = term_collector.get_ontology_terms(base_iris=iris, exclude_deprecated=exclude_deprecated,