Merge pull request #223 from cassiosantana/refactor/222-authors-resou…

…rce-should-be-moved-to-the-admin-namespace refactor/222-authors-resource-should-be-moved-to-the-admin-namespace
cassiosantana · Sep 24, 2023 · 181e946 · 181e946
2 parents 9714ca4 + a825079
commit 181e946
Show file tree

Hide file tree

Showing 20 changed files with 144 additions and 142 deletions.
diff --git a/app/controllers/admin/authors_controller.rb b/app/controllers/admin/authors_controller.rb
@@ -0,0 +1,57 @@
+# frozen_string_literal: true
+
+module Admin
+  class AuthorsController < ApplicationController
+    before_action :set_author, only: %i[show edit update destroy]
+
+    def index
+      @authors = Author.all
+    end
+
+    def show; end
+
+    def new
+      @author = Author.new
+    end
+
+    def edit; end
+
+    def create
+      @author = Author.new(author_params)
+
+      if @author.save
+        redirect_to admin_author_url(@author), notice: "Author was successfully created."
+      else
+        render :new, status: :unprocessable_entity
+      end
+    end
+
+    def update
+      if @author.update(author_params)
+        redirect_to admin_author_url(@author), notice: "Author was successfully updated."
+      else
+        render :edit, status: :unprocessable_entity
+      end
+    end
+
+    def destroy
+      @author.destroy
+
+      redirect_to admin_authors_url, notice: "Author was successfully destroyed."
+    end
+
+    def report
+      @author = Author.includes(:books).find(params[:id])
+    end
+
+    private
+
+    def set_author
+      @author = Author.find(params[:id])
+    end
+
+    def author_params
+      params.require(:author).permit(:name, :cpf)
+    end
+  end
+end
diff --git a/app/controllers/authors_controller.rb b/app/controllers/authors_controller.rb
diff --git a/app/views/authors/_author.html.erb → app/views/admin/authors/_author.html.erb b/app/views/authors/_author.html.erb → app/views/admin/authors/_author.html.erb
diff --git a/app/views/authors/_form.html.erb → app/views/admin/authors/_form.html.erb b/app/views/authors/_form.html.erb → app/views/admin/authors/_form.html.erb
@@ -1,4 +1,4 @@
-<%= form_with(model: author) do |form| %>
+<%= form_with(model: [:admin, author]) do |form| %>
   <% if author.errors.any? %>
     <div style="color: red">
       <h2><%= pluralize(author.errors.count, "error") %> prohibited this author from being saved:</h2>

diff --git a/app/views/admin/authors/edit.html.erb b/app/views/admin/authors/edit.html.erb
@@ -0,0 +1,10 @@
+<h1>Editing author</h1>
+
+<%= render "form", author: @author %>
+
+<br>
+
+<div>
+  <%= link_to "Show this author", admin_author_path(@author) %> |
+  <%= link_to "Back to authors", admin_authors_path %>
+</div>
diff --git a/app/views/authors/index.html.erb → app/views/admin/authors/index.html.erb b/app/views/authors/index.html.erb → app/views/admin/authors/index.html.erb
@@ -7,9 +7,9 @@
     <p>
       <strong>Name:</strong>
       <%= author.name %> |
-      <%= link_to "Show this author", author %>
+      <%= link_to "Show this author", admin_author_path(author) %>
     </p>
   <% end %>
 </div>
 
-<%= link_to "New author", new_author_path %>
+<%= link_to "New author", new_admin_author_path %>
diff --git a/app/views/authors/new.html.erb → app/views/admin/authors/new.html.erb b/app/views/authors/new.html.erb → app/views/admin/authors/new.html.erb
@@ -5,5 +5,5 @@
 <br>
 
 <div>
-  <%= link_to "Back to authors", authors_path %>
+  <%= link_to "Back to authors", admin_authors_path %>
 </div>
diff --git a/app/views/authors/report.html.erb → app/views/admin/authors/report.html.erb b/app/views/authors/report.html.erb → app/views/admin/authors/report.html.erb
@@ -55,5 +55,5 @@
 </section>
 
 <div>
-  <%= link_to "Back to authors", authors_path %>
+  <%= link_to "Back to authors", admin_authors_path %>
 </div>
diff --git a/app/views/admin/authors/show.html.erb b/app/views/admin/authors/show.html.erb
@@ -0,0 +1,11 @@
+<p style="color: green"><%= notice %></p>
+
+<%= render "admin/authors/author", author: @author %>
+
+<div>
+  <%= link_to "Edit this author", edit_admin_author_path(@author) %> |
+  <%= link_to "Back to authors", admin_authors_path %> |
+  <%= link_to "Show report", report_admin_author_path(@author) %>
+
+  <%= button_to "Destroy this author", admin_author_path(@author), method: :delete %>
+</div>
diff --git a/app/views/authors/edit.html.erb b/app/views/authors/edit.html.erb
diff --git a/app/views/authors/show.html.erb b/app/views/authors/show.html.erb
diff --git a/app/views/layouts/application.html.erb b/app/views/layouts/application.html.erb
@@ -11,10 +11,10 @@
     <%= javascript_importmap_tags %>
   </head>
 
-  <body>
+  <body class="prose">
     <nav>
       <%= link_to "Home", root_path %>
-      <%= link_to "Authors", authors_path %>
+      <%= link_to "Authors", admin_authors_path %>
       <%= link_to "Accounts", accounts_path %>
       <%= link_to "Assemblies", assemblies_path %>
       <%= link_to "Parts", parts_path %>

diff --git a/config/routes.rb b/config/routes.rb
@@ -2,12 +2,12 @@
 
 Rails.application.routes.draw do
   resources :accounts, :assemblies, :parts
-  resources :authors, :suppliers do
+  resources :suppliers do
     get :report, on: :member
   end
 
   namespace :admin do
-    resources :books do
+    resources :books, :authors do
       get :report, on: :member
     end
   end

diff --git a/spec/routing/admin/authors_routing_spec.rb b/spec/routing/admin/authors_routing_spec.rb
@@ -0,0 +1,39 @@
+# frozen_string_literal: true
+
+require "rails_helper"
+
+RSpec.describe Admin::AuthorsController, type: :routing do
+  describe "routing" do
+    it "routes to #index" do
+      expect(get: "admin/authors").to route_to("admin/authors#index")
+    end
+
+    it "routes to #new" do
+      expect(get: "admin/authors/new").to route_to("admin/authors#new")
+    end
+
+    it "routes to #show" do
+      expect(get: "admin/authors/1").to route_to("admin/authors#show", id: "1")
+    end
+
+    it "routes to #edit" do
+      expect(get: "admin/authors/1/edit").to route_to("admin/authors#edit", id: "1")
+    end
+
+    it "routes to #create" do
+      expect(post: "admin/authors").to route_to("admin/authors#create")
+    end
+
+    it "routes to #update via PUT" do
+      expect(put: "admin/authors/1").to route_to("admin/authors#update", id: "1")
+    end
+
+    it "routes to #update via PATCH" do
+      expect(patch: "admin/authors/1").to route_to("admin/authors#update", id: "1")
+    end
+
+    it "routes to #destroy" do
+      expect(delete: "admin/authors/1").to route_to("admin/authors#destroy", id: "1")
+    end
+  end
+end
diff --git a/spec/routing/books_routing_spec.rb → spec/routing/admin/books_routing_spec.rb b/spec/routing/books_routing_spec.rb → spec/routing/admin/books_routing_spec.rb
diff --git a/spec/routing/authors_routing_spec.rb b/spec/routing/authors_routing_spec.rb
diff --git a/spec/views/authors/edit.html.erb_spec.rb → ...views/admin/authors/edit.html.erb_spec.rb b/spec/views/authors/edit.html.erb_spec.rb → ...views/admin/authors/edit.html.erb_spec.rb
@@ -2,7 +2,7 @@
 
 require "rails_helper"
 
-RSpec.describe "authors/edit", type: :view do
+RSpec.describe "admin/authors/edit", type: :view do
   let(:author) { create(:author) }
 
   before(:each) do
@@ -11,25 +11,25 @@
   end
 
   it "renders the page title" do
-    expect_page_title("Editing author")
+    expect(rendered).to have_selector("h1", text: "Editing author")
   end
 
   context "editing the author" do
     it "renders the edit author form" do
-      expect(rendered).to have_selector("form[action='#{author_path(author)}'][method='post']")
+      expect(rendered).to have_selector("form[action='#{admin_author_path(author)}'][method='post']")
       expect(rendered).to have_selector("input[name='author[name]'][value='#{author.name}']")
       expect(rendered).to have_selector("input[name='author[cpf]'][value='#{author.cpf}']")
-      expect_submit_button("Update Author")
+      expect(rendered).to have_button("Update Author")
     end
   end
 
   context "rendering links" do
     it "renders the back link" do
-      expect_link_back_to("authors")
+      expect(rendered).to have_link("Back to authors", href: admin_authors_path)
     end
 
     it "renders the show link" do
-      expect_link_to_show(author)
+      expect(rendered).to have_link("Show this author", href: admin_author_path(author))
     end
   end
 end
diff --git a/spec/views/authors/index.html.erb_spec.rb → ...iews/admin/authors/index.html.erb_spec.rb b/spec/views/authors/index.html.erb_spec.rb → ...iews/admin/authors/index.html.erb_spec.rb
@@ -2,7 +2,7 @@
 
 require "rails_helper"
 
-RSpec.describe "authors/index", type: :view do
+RSpec.describe "admin/authors/index", type: :view do
   let(:authors) { create_list(:author, 3) }
 
   before(:each) do
@@ -11,17 +11,17 @@
   end
 
   it "renders the page title" do
-    expect_page_title("Authors")
+    expect(rendered).to have_selector("h1", text: "Authors")
   end
 
   it "renders the link to create a new author" do
-    expect_link_to_new("author")
+    expect(rendered).to have_link("New author", href: new_admin_author_path)
   end
 
   it "renders the list of authors" do
     authors.each do |author|
       expect(rendered).to have_text("Name: #{author.name}", normalize_ws: true)
-      expect(rendered).to have_link("Show this author", href: author_path(author))
+      expect(rendered).to have_link("Show this author", href: admin_author_path(author))
     end
   end
 end
diff --git a/spec/views/authors/new.html.erb_spec.rb → .../views/admin/authors/new.html.erb_spec.rb b/spec/views/authors/new.html.erb_spec.rb → .../views/admin/authors/new.html.erb_spec.rb
@@ -2,23 +2,23 @@
 
 require "rails_helper"
 
-RSpec.describe "authors/new", type: :view do
+RSpec.describe "admin/authors/new", type: :view do
   before(:each) do
     assign(:author, build(:author))
     render
   end
 
   it "renders the page title" do
-    expect_page_title("New author")
+    expect(rendered).to have_selector("h1", text: "New author")
   end
 
   it "renders new author form" do
-    expect(rendered).to have_selector("form[action='#{authors_path}'][method='post']")
+    expect(rendered).to have_selector("form[action='#{admin_authors_path}'][method='post']")
     expect(rendered).to have_selector("input[name='author[name]']")
     expect(rendered).to have_selector("input[name='author[cpf]']")
   end
 
   it "renders the back link" do
-    expect_link_back_to("authors")
+    expect(rendered).to have_link("Back to authors", href: admin_authors_path)
   end
 end