Add data shim so jQuery's data functions also respect domData. #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinbmeyer
requested changes
Apr 19, 2017
can-jquery.js
Outdated
| @@ -11,6 +11,7 @@ var makeArray = require("can-util/js/make-array/make-array"); | |||
| var mutate = require("can-util/dom/mutate/mutate"); | |||
| var setImmediate = require("can-util/js/set-immediate/set-immediate"); | |||
| var canViewModel = require("can-view-model"); | |||
| require("./data.js"); | |||
There was a problem hiding this comment.
.js should probably be removed.
There was a problem hiding this comment.
maybe we should not include this right now, and document this module so people can add it. That way people can experiment with it? This might be a good way to start.
There was a problem hiding this comment.
Good suggestions @justinbmeyer . I've implemented them. Please review and approve.
|
I had to fix how events were dispatched to make the tests pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Posting this for discussion of implementation (though the implementation should work for most cases). This PR adds support for jQuery prototype
.data()and.removeData(), and for static$.data(),$.hasData(), and$.removeData(). In each case, the domData cache from can-util will be examined or updated when the corresponding jQuery data function is called.The jQuery data store takes precedence for getting named properties. For grabbing the full data object, the results from jQuery data and domData are merged together.
$.data()/.data()called as a setter and$.removeData()/.removeData()operate on both caches.Addresses #42