Merge pull request #4 from bzzt/row-filters

Row filters

README.md

@@ -22,6 +22,7 @@ end
 ```
 
 ## Warning!
+
 **WORK IN PROGRESS. DOCUMENTATION MAY BE INCORRECT. DO NOT USE IN PRODUCTION.**
 
 ## Feature List
@@ -53,12 +54,12 @@ end
 - [x] Cells Per Column Limit
 - [x] Row Key Regex
 - [x] Value Regex
+- [x] Family Name Regex
+- [x] Column Qualifier Regex
+- [x] Column Range
+- [x] Timestamp Range
 - [ ] Condition
 - [ ] Row Sample
-- [ ] Family Name Regex
-- [ ] Column Qualifier Regex
-- [ ] Column Range
-- [ ] Timestamp Range
 - [ ] Value Range
 - [ ] Cells Per Row Offset
 - [ ] Cells Per Row Limit

docker-compose.yaml

@@ -2,7 +2,7 @@ version: "3"
 services:
   bigtable-emulator:
     image: shopify/bigtable-emulator
-    command: ["-cf", "dev.test.cf1", "dev.test.cf2"]
+    command: ["-cf", "dev.test.cf1,dev.test.cf2,dev.test.otherFamily"]
     ports:
       - "9035:9035"
     expose:

lib/operations/mutate_row.ex

@@ -47,8 +47,6 @@ defmodule Bigtable.MutateRow do
       stream
       |> Utils.process_stream()
 
-    IO.inspect(result)
-
     {:ok, result}
   end
 

lib/operations/mutate_rows.ex

@@ -49,7 +49,6 @@ defmodule Bigtable.MutateRows do
       stream
       |> Utils.process_stream()
 
-    IO.inspect(result)
     {:ok, result}
   end
 

lib/operations/read_rows.ex

@@ -61,14 +61,9 @@ defmodule Bigtable.ReadRows do
       Connection.get_connection()
       |> Bigtable.Stub.read_rows(request, metadata)
 
-    result =
-      stream
-      |> Utils.process_stream()
-      |> Enum.filter(&contains_chunks?/1)
-
-    IO.inspect(result)
-
-    result
+    stream
+    |> Utils.process_stream()
+    |> Enum.filter(&contains_chunks?/1)
   end
 
   @spec read(binary()) ::
@@ -99,9 +94,4 @@ defmodule Bigtable.ReadRows do
   end
 
   defp contains_chunks?({:ok, response}), do: !Enum.empty?(response.chunks)
-
-  defp remaining_resp?({status, resp}) do
-    IO.puts("ReadRows status: #{inspect(status)}")
-    status != :trailers
-  end
 end

lib/row_filter/column_range.ex

@@ -0,0 +1,43 @@
+defmodule Bigtable.RowFilter.ColumnRange do
+  @moduledoc false
+  alias Google.Bigtable.V2.ColumnRange
+
+  @type column_range :: {binary(), binary(), boolean()} | {binary(), binary()}
+
+  @spec create_range(binary(), column_range) :: ColumnRange.t()
+  def create_range(family_name, {start_qualifier, end_qualifier, inclusive}) do
+    range = translate_range(start_qualifier, end_qualifier, inclusive)
+
+    range
+    |> Keyword.put(:family_name, family_name)
+    |> ColumnRange.new()
+  end
+
+  def create_range(family_name, {start_qualifier, end_qualifier}) do
+    create_range(family_name, {start_qualifier, end_qualifier, true})
+  end
+
+  @spec translate_range(binary(), binary(), boolean()) :: Keyword.t()
+  defp translate_range(start_qualifier, end_qualifier, inclusive) do
+    case inclusive do
+      true -> inclusive_range(start_qualifier, end_qualifier)
+      false -> exclusive_range(start_qualifier, end_qualifier)
+    end
+  end
+
+  @spec exclusive_range(binary(), binary()) :: Keyword.t()
+  defp exclusive_range(start_qualifier, end_qualifier) do
+    [
+      start_qualifier: {:start_qualifier_open, start_qualifier},
+      end_qualifier: {:end_qualifier_open, end_qualifier}
+    ]
+  end
+
+  @spec inclusive_range(binary(), binary()) :: Keyword.t()
+  defp inclusive_range(start_qualifier, end_qualifier) do
+    [
+      start_qualifier: {:start_qualifier_closed, start_qualifier},
+      end_qualifier: {:end_qualifier_closed, end_qualifier}
+    ]
+  end
+end