fix another 500 error on no local collection (#116)

* fix another 500 error on no local collection

* update changelog

changelogs/fragments/114-bugfixes.yml

@@ -1,4 +1,4 @@
 ---
 bugfixes:
-  - Requests for collections that were not already present in artifactory resulted in a 500 internal server error (https://github.com/briantist/galactory/issues/112).
+  - Requests for collections that were not already present in artifactory resulted in a 500 internal server error (https://github.com/briantist/galactory/issues/112, https://github.com/briantist/galactory/pull/116).
   - Requests proxied to a v2 upstream endpoint that supports pagination caused a 400 error from the upstream due to the inclusion of the v3 ``limit`` query string parameter (https://github.com/briantist/galactory/issues/113).

galactory/api/v2/collections.py

@@ -105,7 +105,7 @@ def collection(namespace, collection):
 
     if upstream_result:
         if colgroup is None:
-            result = upstream_result
+            return upstream_result
         else:
             try:
                 upstream_version = VersionInfo.parse(upstream_result['latest_version']['version'])

galactory/api/v3/collections.py

@@ -118,7 +118,7 @@ def collection(namespace, collection):
 
     if upstream_result:
         if colgroup is None:
-            result = upstream_result
+            return upstream_result
         else:
             try:
                 upstream_version = VersionInfo.parse(upstream_result['highest_version']['version'])