Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compatibility with Lichess PGNs (support for multiple games, support for move nits) #14

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

vladkvit
Copy link

The code now supports parsing multiple games and moves such as " 2. f4?! { [%eval -0.26] } "

Known issues:

The move parsing code will still (just like in the upstream repo) inconsistently parse lines like this:

1. e4 { [%eval 0.25] } 1... e5 { [%eval 0.3] } 2. f4?! { [%eval -0.26] } 2... exf4 { [%eval -0.24] } 3. Nf3 { [%eval -0.29] } 3... Be7 { [%eval -0.24] } 

The issue is that the move number is repeated twice and thus the moves aren't grouped together like they should be.

The performance of this code is still slower than python-chess's PGN parse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant