Rethinking external assets 2 #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evalott100
force-pushed
the
rethinking_external_assets_2
branch
7 times, most recently
from
6b855c0
to
4649b1a
Compare
evalott100
force-pushed
the
rethinking_external_assets_2
branch
from
3c0a582
to
2910dfe
Compare
…event_descriptor.py to use a Dtype as a type variable so we can import it from bluesky protocols
coretl
reviewed
Jul 3, 2023
coretl
reviewed
Jul 3, 2023
coretl
reviewed
Jul 3, 2023
… to only have one compose_datum in the ComposeStreamResourceBundle
evalott100
force-pushed
the
rethinking_external_assets_2
branch
from
65cc064
to
78d95b4
Compare
evalott100
force-pushed
the
rethinking_external_assets_2
branch
3 times, most recently
from
c565a96
to
010c410
Compare
…oseEvent and ComposeEventPage
evalott100
force-pushed
the
rethinking_external_assets_2
branch
from
010c410
to
6e8a865
Compare
coretl
reviewed
Jul 11, 2023
coretl
reviewed
Jul 11, 2023
coretl
reviewed
Jul 11, 2023
evalott100
force-pushed
the
rethinking_external_assets_2
branch
from
e011ca7
to
3c60781
Compare
coretl
requested changes
Jul 19, 2023
|
Oh, odd. I know we've retroactively applied |
|
Found it! I'm unsure why these things are changing now though... Maybe a new black release, I think I see some highlights in the recent black releases which match up (I used 23.9.1 locally) 🤔 I'll run black on a different branch off of main and make a new PR. EditNever mind, origin is already black compliant. This branch seems to have a very minor black change so I'll leave it here. Something must have been wrong locally in the last commit. |
evalott100
force-pushed
the
rethinking_external_assets_2
branch
from
5db7b0a
to
e4edddc
Compare
|
Ah, OK, that makes sense. I think we are good to merge then. |
evalott100
force-pushed
the
rethinking_external_assets_2
branch
from
8f5718c
to
6d3d8f2
Compare
evalott100
force-pushed
the
rethinking_external_assets_2
branch
from
98b9905
to
8a23344
Compare
coretl
requested changes
Oct 10, 2023
evalott100
force-pushed
the
rethinking_external_assets_2
branch
from
7025512
to
e57e53b
Compare
coretl
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #236
Putting on a new branch for cleanliness