Remove start restrictions #237
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…model into remove_start_restrictions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes restrictions on certain keys in the start document, addressing #225
Description
Removes restrictions on the following keys in the start document:
Motivation and Context
As discussed in #225 there is little present justification for restricting project, sample, group, or owner, which are not used in any systematic way, and are not planned to be used in a central way that requires validation.
groupandownerin particular are probably holdovers from old notions of how to do unix-permission-based authentication, which is not used in any way. Things likeprojectandsamplecould conceptually be integers, or dictionaries, and should not be limited in their present fashion.How Has This Been Tested?
I tested locally that removing the restrictions does, in fact, allow you to create a start document with the given keys taking arbitrary values. However, it probably doesn't make sense to add any tests to the test suite.