-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Settings] App passwords revamp #5777
base: samuel/settings-5
Are you sure you want to change the base?
Conversation
|
d6f8f33
to
9b14017
Compare
e276015
to
d6b7526
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks so good, especially the animations! 🙌
I've been leaving rather a lot of comments on PRs recently, hopefully I'm not making myself a nuisance 😬
That said, I do have a few suggestions – all nits, of course – for tweaks to strings :)
Thanks @surfdude29! Co-authored-by: surfdude29 <149612116+surfdude29@users.noreply.github.com>
Thanks @surfdude29 - I don't know what I'd do without you! You contributions are extremely appreciated, thanks as always |
Stacked on #5775
Animations tested on iOS, Android, and Web
Simulator.Screen.Recording.-.iPhone.16.-.2024-10-16.at.23.27.32.mp4