Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Settings] App passwords revamp #5777

Open
wants to merge 3 commits into
base: samuel/settings-5
Choose a base branch
from

Conversation

mozzius
Copy link
Member

@mozzius mozzius commented Oct 16, 2024

Stacked on #5775

Animations tested on iOS, Android, and Web

Simulator.Screen.Recording.-.iPhone.16.-.2024-10-16.at.23.27.32.mp4

@mozzius mozzius mentioned this pull request Oct 16, 2024
22 tasks
Copy link

github-actions bot commented Oct 16, 2024

Old size New size Diff
7.98 MB 7.99 MB 11.73 KB (0.14%)

Copy link
Contributor

@surfdude29 surfdude29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks so good, especially the animations! 🙌

I've been leaving rather a lot of comments on PRs recently, hopefully I'm not making myself a nuisance 😬

That said, I do have a few suggestions – all nits, of course – for tweaks to strings :)

src/screens/Settings/AppPasswords.tsx Outdated Show resolved Hide resolved
src/screens/Settings/AppPasswords.tsx Outdated Show resolved Hide resolved
src/screens/Settings/AppPasswords.tsx Outdated Show resolved Hide resolved
src/screens/Settings/components/AddAppPasswordDialog.tsx Outdated Show resolved Hide resolved
src/screens/Settings/components/AddAppPasswordDialog.tsx Outdated Show resolved Hide resolved
src/screens/Settings/components/AddAppPasswordDialog.tsx Outdated Show resolved Hide resolved
src/screens/Settings/components/AddAppPasswordDialog.tsx Outdated Show resolved Hide resolved
src/screens/Settings/components/AddAppPasswordDialog.tsx Outdated Show resolved Hide resolved
Thanks @surfdude29!

Co-authored-by: surfdude29 <149612116+surfdude29@users.noreply.github.com>
@mozzius
Copy link
Member Author

mozzius commented Oct 17, 2024

Thanks @surfdude29 - I don't know what I'd do without you! You contributions are extremely appreciated, thanks as always

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants